Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Register via TTL check for nodes with no agents #371

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Sep 15, 2022

Changes proposed in this PR:

This swaps the health check that's registered as part of the exec process to use TTL-based checks in Consul.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

Copy link
Contributor

@mikemorris mikemorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any significant downside to having this always enabled, even when running with Consul servers in the same network or Kubernetes cluster?

@nathancoleman
Copy link
Member

Andrew Stucki
13 hours ago
Sorry, just saw this -- actually chatted with Mike about that offline awhile ago, there's no downside

@nathancoleman nathancoleman merged commit 83bafda into main Oct 18, 2022
@nathancoleman nathancoleman deleted the agentless-exec branch October 18, 2022 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants