Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Fix SPIFFE url handling #225

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Fix SPIFFE url handling #225

merged 5 commits into from
Jun 15, 2022

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Jun 14, 2022

Changes proposed in this PR:

When users use root connect certificates without SPIFFE information (i.e. via Vault), the controller crashes. This removes the piece of code in our mTLS middleware that verifies the corresponding host between root cert and the derived leaf cert. This should be alright since we're still validating that the root actually generated the leaf certificate cryptographically before these checks.

Fixes: #208

Checklist:

  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@andrewstucki andrewstucki requested a review from a team June 14, 2022 15:59
.changelog/225.txt Outdated Show resolved Hide resolved
Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
@andrewstucki andrewstucki merged commit c35994b into main Jun 15, 2022
@andrewstucki andrewstucki deleted the spiffe-fix branch June 15, 2022 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller crashes when certificates are handled by Vault PKI
2 participants