Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Anti Affinity rules added to deployment spec #202

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Anti Affinity rules added to deployment spec #202

merged 2 commits into from
Jun 6, 2022

Conversation

sarahalsmiller
Copy link
Member

@sarahalsmiller sarahalsmiller commented May 31, 2022 •
edited
Loading

Changes proposed in this PR:

  • Added anti-affinity rule to deployment spec to prevent multiple

How I've tested this PR:

Built a multinode GCP cluster and making sure build schedules nodes appropriately

  • Pods avoid being scheduled on the same node, but if replicas > available nodes the schedule schedules regardless
    Unit tests passing

How I expect reviewers to test this PR:

  • Unit tests passing

Checklist:

  • [ X] Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@sarahalsmiller sarahalsmiller added the pr/no-changelog Skip the CI check that requires a changelog entry label May 31, 2022
@sarahalsmiller sarahalsmiller changed the title WIP- added anti affinity definition to deployment builder Anti Affinity rules added to deployment spec Jun 1, 2022
@sarahalsmiller sarahalsmiller marked this pull request as ready for review June 1, 2022 22:00
@nathancoleman
Copy link
Member

nathancoleman commented Jun 3, 2022 •
edited
Loading

@sarahalsmiller we should probs include a release note here

@nathancoleman nathancoleman removed the pr/no-changelog Skip the CI check that requires a changelog entry label Jun 6, 2022
nathancoleman
nathancoleman reviewed Jun 6, 2022
View reviewed changes
internal/k8s/builder/gateway.go Outdated Show resolved Hide resolved
internal/k8s/builder/gateway.go Outdated Show resolved Hide resolved
nathancoleman
nathancoleman suggested changes Jun 6, 2022
View reviewed changes
.changelog/202.txt Outdated Show resolved Hide resolved
.changelog/202.txt Outdated Show resolved Hide resolved
nathancoleman
nathancoleman approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Had a blast diving into this with ya

@sarahalsmiller sarahalsmiller merged commit a3dc8c8 into main Jun 6, 2022
@sarahalsmiller sarahalsmiller deleted the sa-anti-afinity-rules branch June 6, 2022 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nathancoleman nathancoleman nathancoleman approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahalsmiller @nathancoleman