Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 code block error in console when value is empty on save #2637

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix: 🐛 code block error in console when value is empty on save #2637

merged 2 commits into from
Dec 20, 2024

Conversation

lisbet-alvarez
Copy link
Collaborator

Description

Fix hds code block error manifesting itself when model is saving and code block is empty.

Screenshots (if appropriate)

Error msg:
image

After fix:

Screen.Recording.2024-12-20.at.11.28.05.AM.mov

How to Test

  1. Go to new storage bucket form
  2. Try to save without a value in the code editor
  3. Make sure no error is in the console.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner December 20, 2024 19:29
@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:28pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 8:28pm

ZedLi
ZedLi approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

calcaide
calcaide approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!!! well done work @lisbet-alvarez !!

@lisbet-alvarez lisbet-alvarez merged commit 65abd7a into main Dec 20, 2024
12 checks passed
@lisbet-alvarez lisbet-alvarez deleted the fix-hds-codeblock-error branch December 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcaide calcaide calcaide approved these changes

@ZedLi ZedLi ZedLi approved these changes

Assignees
No one assigned
Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisbet-alvarez @ZedLi @calcaide