Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 application state ability dependent descriptions #2631

Merged
merged 5 commits into from
Dec 18, 2024
Merged

refactor: 💡 application state ability dependent descriptions #2631

merged 5 commits into from
Dec 18, 2024
+1,114 −311

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Dec 14, 2024 •
edited
Loading

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15813

Description

Refactor application state body element to use a getter that returns the correct translation.

How to Test

  1. Unit test cases should be sufficient to test this refactor.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:32pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 11:32pm

@lisbet-alvarez lisbet-alvarez marked this pull request as ready for review December 16, 2024 18:18
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner December 16, 2024 18:18
cameronperera
cameronperera previously approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice refactor to make reading and following the logic a lot cleaner.

@calcaide
Copy link
Collaborator

Tests within all PR are :chef_kiss

calcaide
calcaide previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing refactor @lisbet-alvarez !! this is a very nice improvement for the DX thanks for the nice work!

ZedLi
ZedLi approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible refactor, thanks for this work!!

@lisbet-alvarez lisbet-alvarez merged commit 7695135 into main Dec 18, 2024
12 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-15813-refactor-application-state-ability-dependent-descriptions branch December 18, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronperera cameronperera cameronperera approved these changes

@calcaide calcaide calcaide approved these changes

@ZedLi ZedLi ZedLi approved these changes

Assignees

@lisbet-alvarez lisbet-alvarez

Labels
admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lisbet-alvarez @calcaide @ZedLi @cameronperera