Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› host modal renders whenever there is an error during connection #1936

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Sep 28, 2023

🎟️ Jira ticket

Description

If the connect action were to cause an error then an error modal would render (when connecting from target list view). However, the choose hosts modal would also, incorrectly, render.

Screenshots (if appropriate):

Before:
image
After:
image

How to Test

  1. Start a boundary dev instance.
  2. Create a ssh target with a valid address but no hosts and no injected credentials.
  3. Attempt to connect to the ssh target using the "connect" button in target list view (targets table).
  4. Only an error modal should render. The choose hosts modal should not render.

πŸ–₯️ Desktop preview

Checklist:

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner September 28, 2023 23:25
@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
boundary-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 29, 2023 10:06pm
boundary-ui-desktop βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 29, 2023 10:06pm

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants