From 4550cd0965ea849eb0f1f065d6adf576e433417d Mon Sep 17 00:00:00 2001
From: Devon Anderson <devon.anderson@hashicorp.com>
Date: Thu, 14 Dec 2023 14:48:10 -0500
Subject: [PATCH 1/2] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Migrate=20`host-?=
 =?UTF-8?q?catalog/host-list`=20to=20use=20`Hds`=20(#2044)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 Migrate `host-catalog/host-list` to use `Hds`

Migrate `host-catalog/host-list` to use `Hds::Table`

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11729

* refactor: 💡 `Hds::Text` refactor

Refactored `code` and `p` tag elements to use new `HDS::Text` elements

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11729
---
 .../host-catalog/hosts/index.hbs              | 85 +++++++++----------
 1 file changed, 41 insertions(+), 44 deletions(-)

diff --git a/ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/hosts/index.hbs b/ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/hosts/index.hbs
index a0fa8163d7..37b6978f2e 100644
--- a/ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/hosts/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/host-catalogs/host-catalog/hosts/index.hbs
@@ -22,52 +22,49 @@
 
   <page.body>
     {{#if @model.hosts}}
-      <Rose::Table as |table|>
-        <table.header as |header|>
-          <header.row as |row|>
-            <row.headerCell>{{t 'form.name.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.type.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.id.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.address.label'}}</row.headerCell>
-          </header.row>
-        </table.header>
 
-        <table.body as |body|>
-          {{#each @model.hosts as |host|}}
-            <body.row as |row|>
-              <row.headerCell>
-                {{#if (can 'read model' host)}}
-                  <LinkTo
-                    @route='scopes.scope.host-catalogs.host-catalog.hosts.host'
-                    @model={{host.id}}
-                  >
-                    {{host.displayName}}
-                  </LinkTo>
-                {{else}}
-                  {{host.displayName}}
-                {{/if}}
-                <p>{{host.description}}</p>
-              </row.headerCell>
-              <row.cell>
-                <HostCatalogTypeBadge @model={{host}} />
-              </row.cell>
-              <row.cell>
-                <Copyable
-                  @text={{host.id}}
-                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                  @acknowledgeText={{t 'states.copied'}}
+      <Hds::Table
+        @model={{@model.hosts}}
+        @columns={{array
+          (hash label=(t 'form.name.label'))
+          (hash label=(t 'form.type.label'))
+          (hash label=(t 'form.id.label'))
+          (hash label=(t 'form.address.label'))
+        }}
+      >
+        <:body as |B|>
+          <B.Tr>
+            <B.Td>
+              {{#if (can 'read model' B.data)}}
+                <LinkTo
+                  @route='scopes.scope.host-catalogs.host-catalog.hosts.host'
+                  @model={{B.data.id}}
                 >
-                  <code>{{host.id}}</code>
-                </Copyable>
-              </row.cell>
-
-              <row.cell>
-                <code>{{host.address}}</code>
-              </row.cell>
-            </body.row>
-          {{/each}}
-        </table.body>
-      </Rose::Table>
+                  {{B.data.displayName}}
+                </LinkTo>
+              {{else}}
+                {{B.data.displayName}}
+              {{/if}}
+              <Hds::Text::Body @tag='p'>{{B.data.description}}</Hds::Text::Body>
+            </B.Td>
+            <B.Td>
+              <HostCatalogTypeBadge @model={{B.data}} />
+            </B.Td>
+            <B.Td>
+              <Copyable
+                @text={{B.data.id}}
+                @buttonText={{t 'actions.copy-to-clipboard'}}
+                @acknowledgeText={{t 'states.copied'}}
+              >
+                <Hds::Text::Code>{{B.data.id}}</Hds::Text::Code>
+              </Copyable>
+            </B.Td>
+            <B.Td>
+              <Hds::Text::Code>{{B.data.address}}</Hds::Text::Code>
+            </B.Td>
+          </B.Tr>
+        </:body>
+      </Hds::Table>
 
     {{else}}
       <Rose::Layout::Centered>

From ade1601d8d533d620feddba6469b69df431a2315 Mon Sep 17 00:00:00 2001
From: Devon Anderson <devon.anderson@hashicorp.com>
Date: Thu, 14 Dec 2023 17:27:09 -0500
Subject: [PATCH 2/2] =?UTF-8?q?refactor:=20=F0=9F=92=A1=20Refactor=20`sess?=
 =?UTF-8?q?ions-list`=20to=20use=20`Hds::Table`=20(#2043)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* refactor: 💡 Refactor `sessions-list` to use `Hds::Table`

Refactor `sessions-list` to use `Hds::Table` instead of `Rose::table`

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11732

* refactor: 💡 Use `Hds::Text` component for `code` elements

Refactor `code` elements to use `Hds::Text::Code` component for text.

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11732

* Update ui/admin/app/templates/scopes/scope/sessions/index.hbs

Co-authored-by: Cameron Perera <cameron.perera@hashicorp.com>

* refactor: 💡 Refactor the condition around the `cancelSession`
 route-action, to use the `SessionAbility` for permssion to cancel
 session. Upgrade `Rose::Button` to `Hds::Button`.

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11732

---------

Co-authored-by: Cameron Perera <cameron.perera@hashicorp.com>
---
 ui/admin/app/styles/app.scss                  |   3 +-
 .../templates/scopes/scope/sessions/index.hbs | 125 ++++++++----------
 2 files changed, 58 insertions(+), 70 deletions(-)

diff --git a/ui/admin/app/styles/app.scss b/ui/admin/app/styles/app.scss
index 699de8ac18..3dd3daa5d8 100644
--- a/ui/admin/app/styles/app.scss
+++ b/ui/admin/app/styles/app.scss
@@ -740,7 +740,8 @@
 }
 
 .auth-methods-list-table,
-.workers-list-table {
+.workers-list-table,
+.sessions-list-table {
   margin-top: 1rem;
 }
 
diff --git a/ui/admin/app/templates/scopes/scope/sessions/index.hbs b/ui/admin/app/templates/scopes/scope/sessions/index.hbs
index 604dee22e3..a12b0f71a1 100644
--- a/ui/admin/app/templates/scopes/scope/sessions/index.hbs
+++ b/ui/admin/app/templates/scopes/scope/sessions/index.hbs
@@ -68,76 +68,63 @@
     </Rose::Toolbar>
 
     {{#if @model}}
-      <Rose::Table as |table|>
-        <table.header as |header|>
-          <header.row as |row|>
-            <row.headerCell>{{t 'form.id.label'}}</row.headerCell>
-            <row.headerCell>{{t 'resources.user.title'}}</row.headerCell>
-            <row.headerCell>{{t 'resources.target.title'}}</row.headerCell>
-            <row.headerCell>{{t 'form.started.label'}}</row.headerCell>
-            <row.headerCell>{{t 'form.status.label'}}</row.headerCell>
-            <row.headerCell>{{t 'titles.actions'}}</row.headerCell>
-          </header.row>
-        </table.header>
-        <table.body as |body|>
-          {{#each @model as |sessionAggregate|}}
-            <body.row as |row|>
-              <row.headerCell class='nowrap'>
-                <Rose::Icon
-                  class={{concat
-                    'session-status-'
-                    sessionAggregate.session.status
-                  }}
-                  @name='flight-icons/svg/entry-point-16'
-                  @size='medium'
+
+      <Hds::Table
+        @model={{@model}}
+        class='sessions-list-table'
+        @columns={{array
+          (hash label=(t 'form.id.label'))
+          (hash label=(t 'resources.user.title'))
+          (hash label=(t 'resources.target.title'))
+          (hash label=(t 'form.started.label'))
+          (hash label=(t 'form.status.label'))
+          (hash label=(t 'titles.actions'))
+        }}
+      >
+        <:body as |B|>
+          <B.Tr>
+            <B.Td>
+              <Rose::Icon
+                class={{concat 'session-status-' B.data.session.status}}
+                @name='flight-icons/svg/entry-point-16'
+                @size='medium'
+              />
+              <Copyable
+                @text={{B.data.session.id}}
+                @buttonText={{t 'actions.copy-to-clipboard'}}
+                @acknowledgeText={{t 'states.copied'}}
+              >
+                <Hds::Text::Code>{{B.data.session.id}}</Hds::Text::Code>
+              </Copyable>
+            </B.Td>
+            <B.Td>
+              <Hds::Text::Code>{{B.data.user.id}}</Hds::Text::Code>
+              {{#if B.data.user.accountName}}
+                <br />
+                <Hds::Badge @text={{B.data.user.accountName}} />
+              {{/if}}
+            </B.Td>
+            <B.Td>{{B.data.target.displayName}}</B.Td>
+            <B.Td>
+              <time datetime={{format-date-iso B.data.session.created_time}}>
+                {{format-date-iso-human B.data.session.created_time}}
+              </time>
+            </B.Td>
+            <B.Td>
+              <SessionStatus @model={{B.data.session}} />
+            </B.Td>
+            <B.Td>
+              {{#if (can 'cancel session' B.data.session)}}
+                <Hds::Button
+                  @color='secondary'
+                  @text={{t 'actions.cancel'}}
+                  {{on 'click' (route-action 'cancelSession' B.data.session)}}
                 />
-                <Copyable
-                  @text={{sessionAggregate.session.id}}
-                  @buttonText={{t 'actions.copy-to-clipboard'}}
-                  @acknowledgeText={{t 'states.copied'}}
-                >
-                  <code>{{sessionAggregate.session.id}}</code>
-                </Copyable>
-              </row.headerCell>
-              <row.cell>
-                <code>{{sessionAggregate.user.id}}</code>
-                {{#if sessionAggregate.user.accountName}}
-                  <br />
-                  <Hds::Badge @text={{sessionAggregate.user.accountName}} />
-                {{/if}}
-              </row.cell>
-              <row.cell>{{sessionAggregate.target.displayName}}</row.cell>
-              <row.cell>
-                <time
-                  datetime={{format-date-iso
-                    sessionAggregate.session.created_time
-                  }}
-                >
-                  {{format-date-iso-human
-                    sessionAggregate.session.created_time
-                  }}
-                </time>
-              </row.cell>
-              <row.cell>
-                <SessionStatus @model={{sessionAggregate.session}} />
-              </row.cell>
-              <row.cell>
-                {{#if sessionAggregate.session.isAvailable}}
-                  <Rose::Button
-                    @style='secondary'
-                    {{on
-                      'click'
-                      (route-action 'cancelSession' sessionAggregate.session)
-                    }}
-                  >
-                    {{t 'actions.cancel'}}
-                  </Rose::Button>
-                {{/if}}
-              </row.cell>
-            </body.row>
-          {{/each}}
-        </table.body>
-      </Rose::Table>
+              {{/if}}
+            </B.Td>
+          </B.Tr>
+        </:body>
+      </Hds::Table>
 
     {{else if
       (has-resource-filter-selections 'scopes.scope.sessions' 'status')