Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared AWS SDK for Go v2 Retryer leading to increased QuotaExceededException API throttling errors #915

Closed
ewbankkit opened this issue Feb 13, 2024 · 0 comments · Fixed by #918

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 13, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

The AWS SDK for Go v2 SDK retryer uses a token bucket for retrying throttling errors.
The documentation for the aws.Config.Retryer field (a function that returns a Retryer interface implementation) recommends:

	// In general, the provider function should return a new instance of a
	// Retryer if you are attempting to provide a consistent Retryer
	// configuration across all clients. This will ensure that each client will
	// be provided a new instance of the Retryer implementation, and will avoid
	// issues such as sharing the same retry token bucket across services.

Currently this module configures aws.Config.Retryer to return a wrapper on top of a shared base implementation. This means that the token bucket is shared between ALL service clients.
With large Terraform configurations this can lead to an increased frequency of QuotaExceededException API throttling errors.

Relates hashicorp/terraform-provider-aws#34669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant