Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change mirror node and explorer from subchart to individual chart #743

Merged
merged 27 commits into from
Oct 31, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Oct 25, 2024

Description

This pull request changes the following:

  • change mirror node and explorer from subchart to individual chart

Related Issues


Notes

Mus not use hedera-mirror as release name, since
k8 would auto generate env variable ${SERVICE_NAME}_PORT
which lead to a new HEDERA_MIRROR_REST_PORT clash with pre-existing env variable
used by mirror node.

https://stackoverflow.com/questions/45759205/what-environment-variables-are-created-in-kubernetes-by-default

image

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners October 25, 2024 00:21
@JeffreyDallas JeffreyDallas self-assigned this Oct 25, 2024
…update-mirror-node-chart

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/mirror_node.ts
#	src/commands/prompts.ts
#	src/core/constants.ts
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Unit Test Results - Linux

  1 files   38 suites   10s ⏱️
 98 tests  98 ✅ 0 💤 0 ❌
107 runs  107 ✅ 0 💤 0 ❌

Results for commit 7144b1b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 25, 2024

Unit Test Results - Windows

  1 files   38 suites   21s ⏱️
 98 tests  98 ✅ 0 💤 0 ❌
107 runs  107 ✅ 0 💤 0 ❌

Results for commit 7144b1b.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…update-mirror-node-chart

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>

# Conflicts:
#	src/commands/flags.ts
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Co-authored-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com>
jeromy-cannon
jeromy-cannon previously approved these changes Oct 28, 2024
@jeromy-cannon jeromy-cannon self-requested a review October 28, 2024 16:41
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link
Contributor

github-actions bot commented Oct 30, 2024

E2E Test Report

 16 files  105 suites   1h 1m 33s ⏱️
205 tests 205 ✅ 0 💤 0 ❌
208 runs  208 ✅ 0 💤 0 ❌

Results for commit 7144b1b.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 74173841 83.74%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7417384) Report Missing Report Missing Report Missing
Head commit (7144b1b) 13116 11585 88.33%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#743) 123 103 83.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 82.11382% with 22 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (b66fe05) to head (7144b1b).
Report is 186 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 77.04% 12 Missing and 2 partials ⚠️
src/commands/prompts.ts 40.00% 6 Missing ⚠️
src/core/profile_manager.ts 92.85% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   87.09%   87.29%   +0.20%     
==========================================
  Files          40       42       +2     
  Lines       12545    13116     +571     
  Branches      944     1026      +82     
==========================================
+ Hits        10926    11450     +524     
- Misses       1568     1612      +44     
- Partials       51       54       +3     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.50% <100.00%> (+<0.01%) ⬆️
src/commands/network.ts 76.59% <ø> (+0.17%) ⬆️
src/core/constants.ts 96.42% <100.00%> (+0.27%) ⬆️
version.ts 100.00% <100.00%> (ø)
src/core/profile_manager.ts 94.63% <92.85%> (-0.64%) ⬇️
src/commands/prompts.ts 64.49% <40.00%> (-0.52%) ⬇️
src/commands/mirror_node.ts 76.82% <77.04%> (-0.70%) ⬇️

... and 12 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 58f0496 into main Oct 31, 2024
41 of 43 checks passed
@jeromy-cannon jeromy-cannon deleted the 00617-D-update-mirror-node-chart branch October 31, 2024 10:27
swirlds-automation added a commit that referenced this pull request Dec 31, 2024
## [0.32.0](v0.31.1...v0.32.0) (2024-12-31)

### ⚠ BREAKING CHANGES

* update readme with warning about BREAKING CHANGE in this next release (#730)

### Features

* add ci test flow to test task command to launch solo ([#811](#811)) ([356f341](356f341))
* add example for using javascript SDK ([#832](#832)) ([1d9452e](1d9452e))
* add extended math utils and duration support ([#923](#923)) ([f5a69e7](f5a69e7))
* add separate commands for update ([#735](#735)) ([44c3132](44c3132))
* add solo smoke test to test flow ([#905](#905)) ([79410f0](79410f0))
* add support for flexible lease acquisition and production readiness ([#830](#830)) ([7fa86ad](7fa86ad))
* Add the ability to inject a ca certificate for use in gRPC and gRPC Web ([#753](#753)) ([2cd8a38](2cd8a38))
* add timeout flag to network destroy command ([#821](#821)) ([0fb570b](0fb570b))
* allow settings a reserved static IP address for the consensus nodes HAProxy and Envoy Proxy though the cli with flags ([#937](#937)) ([de9ec2e](de9ec2e))
* change mirror node and explorer from subchart to individual chart ([#743](#743)) ([58f0496](58f0496))
* Create a local config for storing configurations on the users machine ([#803](#803)) ([0a4382d](0a4382d))
* Create remote config  ([#862](#862)) ([e8fe739](e8fe739))
* dynamically construct the genesis-network.json and add it to the values file to be used during network deploy ([#982](#982)) ([1b9b7e6](1b9b7e6))
* expose pod check attempts and delays as environment controlled variables ([#812](#812)) ([a7b3279](a7b3279))
* Implement IOC ([#1010](#1010)) ([ed23a7b](ed23a7b))
* Implement solo context connect ([#863](#863)) ([782b3ec](782b3ec))
* Increase helm chart version and switch to use oci registry ([#788](#788)) ([1973275](1973275))
* **k8s:** introduce Kubernetes lease lock mechanism ([#707](#707)) ([f1b8089](f1b8089))
* new command to save state files and upload state files ([#849](#849)) ([d5a9a18](d5a9a18))
* removed caching of ConfigManager and its flags ([#713](#713)) ([76a61e3](76a61e3))
* Setup mirror node monitor pinger service ([#893](#893)) ([f4c4320](f4c4320))
* update `solo context connect` to connect to single remote cluster ([#993](#993)) ([c9711c5](c9711c5))
* Update document ([#956](#956)) ([b378937](b378937))
* update readme and hugo workflow ([#930](#930)) ([0e08abc](0e08abc))
* Validate a remote config ([#922](#922)) ([a7bbae0](a7bbae0))

### Bug Fixes

* add delay before calling script ([#955](#955)) ([76f4b81](76f4b81))
* allow expired leases to be overwritten ([#828](#828)) ([1fa1d78](1fa1d78))
* bump chart and hedera version,  re-enable node add ([#985](#985)) ([9cae011](9cae011))
* check if setup chart installed or not before network deploy ([#799](#799)) ([6930dab](6930dab))
* document typo ([#988](#988)) ([8e4fe04](8e4fe04))
* Error in `node update` separate commands when new admin key is not supplied ([#854](#854)) ([6e472b5](6e472b5))
* Examples of performance configs for HashSphere and Latitude ([#926](#926)) ([#957](#957)) ([928148b](928148b))
* fix missing file issues when running solo from npm install -g ([#736](#736)) ([2a5cfc1](2a5cfc1))
* fixed genesis-network.json file lock issue ([#1074](#1074)) ([e590516](e590516))
* flag check of node logs command and incorrect download source ([#848](#848)) ([03051f0](03051f0))
* inconsistent failures ([#866](#866)) ([13ea46d](13ea46d))
* local chart directory not being taken correctly ([#983](#983)) ([58e96e1](58e96e1))
* nextNode ID for release version > 0.56.0 ([#765](#765)) ([3b98dd6](3b98dd6))
* node id should start from `1` ([#884](#884)) ([d90c9b5](d90c9b5))
* node update with single node ([#981](#981)) ([74285bf](74285bf))
* patch issue with dist folder not showing up ([#733](#733)) ([077f989](077f989))
* performance improvements for node stop ([#986](#986)) ([437bbc6](437bbc6))
* refactored Taskfiles, fixed bugs with taskfile, lease interval, sdk node client connection, and commands missing quiet flag ([#978](#978)) ([7bb0e99](7bb0e99))
* remote config validation not working ([#967](#967)) ([88c2506](88c2506))
* resolve node update test failures ([#856](#856)) ([5e1c652](5e1c652))
* Revised example configs for Latitude deployment, automation friendly ([#1038](#1038)) ([434daf3](434daf3))
* undefined log output of namespace ([#764](#764)) ([ac15957](ac15957))

### Documentation

* update readme with warning about BREAKING CHANGE in this next release ([#730](#730)) ([06295f6](06295f6))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mirror node deployment to deploy mirror node external of Solo Charts, similar to JSON RPC Relay
3 participants