Skip to content

Commit 95cc0c2

Browse files
committed
remove TODOs that have been done
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
1 parent 77b769f commit 95cc0c2

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

src/core/kube/resources/lease/leases.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ export interface Leases {
1313
* @param durationSeconds - the duration of the lease in seconds\
1414
* @returns the created lease
1515
*/
16-
create(namespace: NamespaceName, leaseName: string, holderName: string, durationSeconds: number): Promise<V1Lease>; // TODO was createNamespacedLease
16+
create(namespace: NamespaceName, leaseName: string, holderName: string, durationSeconds: number): Promise<V1Lease>;
1717

1818
/**
1919
* Delete a lease
2020
* @param namespace - the namespace of the lease
2121
* @param name - the name of the lease
2222
* @returns the status of the deletion
2323
*/
24-
delete(namespace: NamespaceName, name: string): Promise<V1Status>; // TODO was deleteNamespacedLease
24+
delete(namespace: NamespaceName, name: string): Promise<V1Status>;
2525

2626
/**
2727
* Returns the lease with the specified name
@@ -30,7 +30,7 @@ export interface Leases {
3030
* @param timesCalled - the number of times this function has been called
3131
* @returns a list of lease names
3232
*/
33-
read(namespace: NamespaceName, leaseName: string, timesCalled?: number): Promise<any>; // TODO was readNamespacedLease
33+
read(namespace: NamespaceName, leaseName: string, timesCalled?: number): Promise<any>;
3434

3535
/**
3636
* Renew a lease
@@ -39,13 +39,13 @@ export interface Leases {
3939
* @param lease - the lease object
4040
* @returns the renewed lease
4141
*/
42-
renew(namespace: NamespaceName, leaseName: string, lease: V1Lease): Promise<V1Lease>; // TODO was renewNamespaceLease
42+
renew(namespace: NamespaceName, leaseName: string, lease: V1Lease): Promise<V1Lease>;
4343

4444
/**
4545
* Transfer a lease
4646
* @param lease - the lease object
4747
* @param newHolderName - the name of the new lease holder
4848
* @returns the transferred lease
4949
*/
50-
transfer(lease: V1Lease, newHolderName: string): Promise<V1Lease>; // TODO was transferNamespaceLease
50+
transfer(lease: V1Lease, newHolderName: string): Promise<V1Lease>;
5151
}

src/core/kube/resources/secret/secrets.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export interface Secrets {
2121
secretType: SecretType,
2222
data: Record<string, string>,
2323
labels: Optional<Record<string, string>>,
24-
): Promise<boolean>; // TODO was createSecret
24+
): Promise<boolean>;
2525

2626
createOrReplace(
2727
namespace: NamespaceName,
@@ -48,15 +48,15 @@ export interface Secrets {
4848
namespace: string;
4949
type: string;
5050
labels: Record<string, string>;
51-
}>; // TODO was getSecret
51+
}>;
5252

5353
/**
5454
* Delete a secret from the namespace
5555
* @param namespace - the namespace to store the secret
5656
* @param name - the name of the existing secret
5757
* @returns whether the secret was deleted successfully
5858
*/
59-
delete(namespace: NamespaceName, name: string): Promise<boolean>; // TODO was deleteSecret
59+
delete(namespace: NamespaceName, name: string): Promise<boolean>;
6060

6161
/**
6262
* Get secrets by labels
@@ -75,9 +75,7 @@ export interface Secrets {
7575
type: string;
7676
labels: Record<string, string>;
7777
}>
78-
>; // TODO was getSecretsByLabel(labels: string[]): Promise<any>
79-
// TODO consolidate getSecret into listByLabel
80-
// TODO consolidate listSecretsByNamespace into listByLabel
78+
>;
8179

82-
exists(namespace: NamespaceName, name: string): Promise<boolean>; // TODO was secretExists
80+
exists(namespace: NamespaceName, name: string): Promise<boolean>;
8381
}

src/core/kube/resources/service/services.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ export interface Services {
1111
* @param namespace - namespace
1212
* @param name - service name
1313
*/
14-
read(namespace: NamespaceName, name: string): Promise<Service>; // TODO was getSvcByName
14+
read(namespace: NamespaceName, name: string): Promise<Service>;
1515

1616
/**
1717
* List all services in a namespace
1818
* @param namespace - namespace
1919
* @param labels - labels
2020
*/
21-
list(namespace: NamespaceName, labels?: string[]): Promise<Service[]>; // TODO was listSvcs
21+
list(namespace: NamespaceName, labels?: string[]): Promise<Service[]>;
2222

2323
/**
2424
* Create a service

0 commit comments

Comments
 (0)