Skip to content

Commit 7f7e4a8

Browse files
jeromy-cannonjeromy-cannon
committed
remove node-add from workflows
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
1 parent 4d7e1f0 commit 7f7e4a8

File tree

2 files changed

+27
-23
lines changed

2 files changed

+27
-23
lines changed

‎.github/workflows/flow-build-application.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,11 @@ jobs:
8282
- { name: "Node PEM Kill", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-pem-kill-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-pem-kill-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-pem-kill-coverage-report }}" }
8383
- { name: "Node Local Hedera", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-local-hedera-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-local-hedera-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-local-hedera-coverage-report }}" }
8484
- { name: "Node Local PTT", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-local-ptt-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-local-ptt-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-local-ptt-coverage-report }}" }
85-
- { name: "Node Add", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}" }
86-
- { name: "Node Add Local", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-local-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-local-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-local-coverage-report }}" }
87-
- { name: "Node Add - Separate commands", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-separate-commands-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-separate-commands-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-separate-commands-coverage-report }}" }
85+
# Node Add tests are disabled and are not viable for the amount of memory available. The teacher crashes during
86+
# the reconnect attempt.
87+
# - { name: "Node Add", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-coverage-report }}" }
88+
# - { name: "Node Add Local", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-local-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-local-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-local-coverage-report }}" }
89+
# - { name: "Node Add - Separate commands", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-add-separate-commands-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-add-separate-commands-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-add-separate-commands-coverage-report }}" }
8890
- { name: "Node Update", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-update-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-update-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-update-coverage-report }}" }
8991
- { name: "Node Update - Separate commands", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-update-separate-commands-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-update-separate-commands-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-update-separate-commands-coverage-report }}" }
9092
- { name: "Node Delete", npm-test-script: "test-${{ needs.env-vars.outputs.e2e-node-delete-test-subdir }}", coverage-subdirectory: "${{ needs.env-vars.outputs.e2e-node-delete-test-subdir }}", coverage-report-name: "${{ needs.env-vars.outputs.e2e-node-delete-coverage-report }}" }

‎.github/workflows/zxc-code-analysis.yaml

+22-20
Original file line numberDiff line numberDiff line change
@@ -314,26 +314,28 @@ jobs:
314314
name: ${{ inputs.e2e-node-local-ptt-coverage-report }}
315315
path: 'coverage/${{ inputs.e2e-node-local-ptt-test-subdir }}'
316316

317-
- name: Download E2E Node Add Coverage Report
318-
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
319-
if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
320-
with:
321-
name: ${{ inputs.e2e-node-add-coverage-report }}
322-
path: 'coverage/${{ inputs.e2e-node-add-test-subdir }}'
323-
324-
- name: Download E2E Node Add Local Coverage Report
325-
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
326-
if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
327-
with:
328-
name: ${{ inputs.e2e-node-add-local-coverage-report }}
329-
path: 'coverage/${{ inputs.e2e-node-add-local-test-subdir }}'
330-
331-
- name: Download E2E Node Add - Separate commands Coverage Report
332-
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
333-
if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
334-
with:
335-
name: ${{ inputs.e2e-node-add-separate-commands-coverage-report }}
336-
path: 'coverage/${{ inputs.e2e-node-add-separate-commands-test-subdir }}'
317+
# Node Add tests are disabled and are not viable for the amount of memory available. The teacher crashes during
318+
# the reconnect attempt.
319+
# - name: Download E2E Node Add Coverage Report
320+
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
321+
# if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
322+
# with:
323+
# name: ${{ inputs.e2e-node-add-coverage-report }}
324+
# path: 'coverage/${{ inputs.e2e-node-add-test-subdir }}'
325+
#
326+
# - name: Download E2E Node Add Local Coverage Report
327+
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
328+
# if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
329+
# with:
330+
# name: ${{ inputs.e2e-node-add-local-coverage-report }}
331+
# path: 'coverage/${{ inputs.e2e-node-add-local-test-subdir }}'
332+
#
333+
# - name: Download E2E Node Add - Separate commands Coverage Report
334+
# uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
335+
# if: ${{ (inputs.enable-codecov-analysis || inputs.enable-codacy-coverage) && inputs.enable-e2e-coverage-report && !cancelled() && !failure() }}
336+
# with:
337+
# name: ${{ inputs.e2e-node-add-separate-commands-coverage-report }}
338+
# path: 'coverage/${{ inputs.e2e-node-add-separate-commands-test-subdir }}'
337339

338340
- name: Download E2E Node Update Coverage Report
339341
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8

0 commit comments

Comments
 (0)