Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Add AccountDelete method #2497

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR implements the AccountDelete JSON-RPC method and successfully validated its functionality through comprehensive tests within the TCK project.

Related issue(s):
#2448

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…interfaces

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Copy link

@ivaylogarnev-limechain ivaylogarnev-limechain changed the title feat: Added accountDelete JSONRPC method in the TCK and the relevant … feat(TCK): Add AccountDelete method Aug 30, 2024
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit e717d4f into main Sep 2, 2024
13 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the feat/2448-tck-account-delete branch September 2, 2024 12:01
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Sep 12, 2024
ivaylogarnev-limechain added a commit that referenced this pull request Sep 19, 2024
…interfaces (#2497)

Signed-off-by: ivaylogarnev-limechain <ivaylo.garnev@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-JS: Implement JSON-RPC methods for AccountDeleteTransaction
4 participants