Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False revoke message in TrustChain #1679

Closed
AlexIvanHoward opened this issue Jan 22, 2023 · 0 comments
Closed

False revoke message in TrustChain #1679

AlexIvanHoward opened this issue Jan 22, 2023 · 0 comments
Assignees
Labels
bug Something isn't working community

Comments

@AlexIvanHoward
Copy link
Contributor

Problem description

The TrustChain viewer displays a "Revoke" message for any VC of which the "comment" field is not empty, even if the VC has in fact been approved.

Steps to reproduce

Steps to reproduce the behavior:

  1. Import the testnet 'False revoke in TrustChain' policy via message identifier 1674400089.918995655
  2. Open the policy in Dry Run mode.
  3. Create a user other than the existing 'Administrator' user.
  4. Switch to the user created in step 3 ("Virtual User 1").
  5. Select 'PROJECT_DEVELOPER' as the role when prompted.
  6. Complete Form A.
  7. Switch to the Administrator user.
  8. Click on the 'Approve' button for the document which you have just created as Virtual User 1. You should now be prompted for any additional comments to provide to the applicant. Enter "Welcome!" and click 'Ok'.
  9. Notice how the status of the document (as shown in column 'Status' of the grid) changed from "NONE" to "APPROVED".
  10. Switch back to Virtual User 1.
  11. Complete Form B.
  12. Switch to the Administrator user.
  13. Click on the 'Approve' button for the Form B document which you have just created as Virtual User 1 in step 10 above. You should now be prompted for any additional comments to provide to the applicant. Enter "Great choice!" and click 'Ok'.
  14. Notice how the status of the document (as shown in column 'Status' of the grid) changed from "NONE" to "APPROVED".
  15. Create a second additional user, Virtual User 2, for the policy in Dry Run and switch to them.
  16. Select 'VIEWER' as the role when prompted.
  17. You should now be presented with a grid containing one document. Click on the 'View TrustChain' link for the document.
  18. Inspect the TrustChain displayed at the bottom of the screen. Notice how the "card" for the Form A VC shows, "Revoked with reason: 'Welcome!'", although the document has in fact been approved. Similarly, notice how the "card" for the Form B VC shows, "Revoked with reason: 'Great choice!'", although the document has in fact been approved. See screenshot below.

Expected behavior

VCs of which the "comment" field is not empty should not be displayed as "Revoked" by default in the TrustChain. Values in the "comment" field of a VC should rather be displayed in an neutral way in the TrustChain, because they can be either acceptance messages or rejection reasons, not just the latter.

Screenshots

FalseRevoke

@prernaadev01 prernaadev01 added bug Something isn't working community labels Jan 24, 2023
anvabr pushed a commit that referenced this issue Mar 27, 2023
### Enhancements
- Dependent fields in schemas [#1561](#1561)
- User topic and Initialization topic to be clickable [#1884](#1884)
- Wrong response for particular request (schema delete  [#1882](#1882)
- Trust chain to support N:1 aggregation from multiple MRV-generators to tokens [#1069](#1069)
- New PRs should go to develop [#1832](#1832)
- Adding drop down arrow for Menu in UI [#1883](#1883)

### Bugs Fixed
- TokenIds are in UUID format [#1913](#1913)
- 2.10 - get-block-data timeout [#1893](#1893)
- Guardian 2.9.3 rendering issues on OS X [#1778](#1778)
- Drop down menu is not displayed in Safari [#1880](#1880)
- Multi-button blocks with filters don't work [#1677](#1677)
- False revoke message in TrustChain [#1679](#1679)
- IPFS - resource limit exceeded [#1812](#1812)

### Changelog

* rename buttons
Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* update

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* Create README.md

* Create README.md

* added policy

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-277: Added Help Text Schema Type

* update

* GITBOOK-278: Added blocks

* added history, selective attribute blocks

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* updated policy converter

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* deprecate property view history on source addons

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fixed get VP record

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fixed autoresizing on help text

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix policy converter

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-279: High Level Architecture updated

* Updated KrypC ReadMe

* Delete README.md

* Updated Demo Artifacts ReadMe

* fix multipolicy

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix policy groups

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* update

* added vc selective closure

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix docker build

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-281: added two new blocks

* update

* update

* update

* fix signatures

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* configureation validation

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* set ids for nested objects

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update

* fix validation

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix bad state answers

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* Using the new kubo 0.18 docker image;

Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com>

* update

* remove inputFields property from custom logic block

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* GITBOOK-282: updated retirement screenshots

* added new verra redd policy [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* added not found documents item to trustchain

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix artifact's error messages, added comments

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix lint

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix payload too large issue

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* change default value for json request limit

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* гзвфеу

* update

* fix display image fields

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* create tokens when policy publish

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* merge develop

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* ipfs node version

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix validation

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix validation

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* update

* update

* update

* remove

* remove

* Update CONTRIBUTING.md

new PRs shoud go to develop

Signed-off-by: noel garcia <noel.garcia@intellecteu.com>

* remove hardcoded transaction fee

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* added nodes settings

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* added custom nodes to policy process

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* up hedera sdk version

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* remove CUSTOM_CLIENT_NODES setting

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix lint

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fixed convert bytes to base64 image

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix visible for draft tokens in retire dialog

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix create and import draft tokens

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* publish tokens

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix header

* fix token type visible for dynamic tokens

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix validation

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix undo\redo

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* GITBOOK-286: Selective Disclosure changes

* GITBOOK-287: Added env parameters for hedera custom nodes

* fix

* fix

* GITBOOK-288: updated docs : docker config for M1

* Create README.md

* Create README.md

* fix

* Add files via upload

* Updated Description

* added modules api to swagger

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* remove logs from modules api

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix module validation

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix import module

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix worker exceptions

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* added menu modules endpoint, fixes

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* add new config

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* refactor

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix create new module

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix style

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* add demo artifacts

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix mint draft tokens

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* moved verra redd 4 [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* bump version

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* Rename "Demo Artifacts" to "Methodology Library"

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix search

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* GITBOOK-289: Module APIs

* Corrected links in ReadMe of Methodology Library

* corrected links in ReadMe

* corrected links in irec readme

* fix mathjs

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* Updated links in Verra ReadMe

* fix mathjs

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* Added VM0017 ReadMe

* Updated ReadMe

* Delete

* GITBOOK-290: Added enable individual filters property

* fix workflow

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix workflow

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix workflow

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix workflow

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* add workflow_dispatch to publish workflow

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix root tag

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix menu style

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* fix convert to module

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* added disabling user grouping

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix displaying sub menu for safari

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* #1882 update error message

* #1882 update error message

* update nav menu

* GITBOOK-291: Modules Demo using UI

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* added custom pattern to schema configuration

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix string type with custom pattern

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix pattern property for other types

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* clickable user info

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* updates swagger [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-292: Added pattern input description for String field type

* GITBOOK-293: Added timestamp for modules

* fix

Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>

* added geoJSON type

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update swagger [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* change type name

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix publish policy file

* GITBOOK-295: Added GeoJSON Schema type

* GITBOOK-296: added Map API

* added verra redd 5 policy [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-298: added operator id and key note

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-299: added prerequisites version

* added uri schema type

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* multiple instances

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix policy start

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix lint

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix build
Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix
Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix build

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix logs

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix lint

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix build

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* temporary skip tests

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix tests exit

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* GITBOOK-300: Added INITIALIZATION TOPIC IDs for networks

* GITBOOK-302: Updated Roadmap

* fixed type polygon in geojson

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* update document state entity in guardian-service

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix import policy

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix login crash

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* update verra redd 5 policy [skip ci]

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix uri ui validator

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* swap coordinates for geojson

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* rework worker-queue

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix policy processes

Signed-off-by: artembuslaev <buslaew.ar@mail.ru>

* fix lint

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* GITBOOK-303: Removed UI Properties of InterfaceStep Block

* fix map api authorization error
increase workers queues speed

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix policy ready receiver

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* worker tasks optimization

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* start instance script

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* fix litn
Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

* bump version

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>

---------

Signed-off-by: simvalery <valeriy.simonov@envisionblockchain.com>
Signed-off-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>
Signed-off-by: artembuslaev <buslaew.ar@mail.ru>
Signed-off-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com>
Signed-off-by: noel garcia <noel.garcia@intellecteu.com>
Co-authored-by: Stepan Kiryakov <stepan.kiryakov@envisionblockchain.com>
Co-authored-by: prernaadev01 <79293833+prernaadev01@users.noreply.github.com>
Co-authored-by: artembuslaev <buslaew.ar@mail.ru>
Co-authored-by: prernaa.agarwal <prernaa.agarwal@envisionblockchain.com>
Co-authored-by: artembuslaev <68849616+artembuslaev@users.noreply.github.com>
Co-authored-by: Giuseppe Bertone <giuseppe.bertone@swirldslabs.com>
Co-authored-by: Noel Garcia <wolfwolker@users.noreply.github.com>
Co-authored-by: Stepan Kirjakov <84465157+Stepan-Kirjakov@users.noreply.github.com>
Co-authored-by: dubgeis <62163252+dubgeis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community
Projects
None yet
Development

No branches or pull requests

4 participants