[backport v1.3] [BUG] Upgrade can be started while previous upgrade still in progress

[harvesterhci-io-github-bot]

backport the issue #6144

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
  The HEP PR is at:

• Where is the reproduce steps/test steps documented?
  The reproduce steps/test steps are at:

• Is there a workaround for the issue? If so, where is it documented?
  The workaround is at:

• Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
  The PR is at:

  • Does the PR include the explanation for the fix or the feature?

  • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
    The PR for the YAML change is at:
    The PR for the chart change is at:

• If labeled: area/ui Has the UI issue filed or ready to be merged?
  The UI issue/PR is at:

• If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
  The documentation/KB PR is at:

• If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
  The compatibility issue is filed at:

[TachunLin]

Verified not fixed on v1.3-81d64ff-head (v1.3.2-head). Found one of the case would be failed.
Move to the implement for further investigation.

Result

$\color{green}{\textsf{PASS}}$ When there is a Harvester version upgrade already started, the upgrade trigger button will automatically disappeared. All the other version upgrade can't be trigger afterward. $~~$

1. When we have multiple upgrade version in the list, (v1.3.2-head and v1.4.0-head)
   

2. After we trigger the v1.3.2-head upgrade, the upgrade button will automatically disappear

https://github.com/user-attachments/assets/cc194899-bc77-4df5-b8ce-218bf019f30a

$\color{red}{\textsf{Failed}}$ But when there are two versions of upgrade, when one upgrade failed, the upgrade button will show up again $~~$

Test Information

• Test Environment: Three nodes harvester on remote kvm machines
• Harvester version: v1.3-81d64ff-head

Verify Steps

Two upgrade version in the lists

1. Use ipxe-examples to provision a three nodes Harvester
2. Prepare the v1.3-head and v1.4-head iso image on the pxe_server
3. Create the corresponding version.yaml file on Harvester node
4. Create the v1.3.2-head and v1.4.0-head upgrade CR on Harvester node
5. Check the upgrade button appear on the Host page
6. Trigger the v1.3.2-head upgrade
7. Check the upgrade button should be disappeared.

[a110605]

vokoscreenNG-2024-08-09_17-11-32.mp4

Hi @TachunLin , according to the fixed PR logic, if this is the latest upgrade and upgrade result is failed or success.

We will show yellow upgrade button again.

[a110605]

Hi @TachunLin , as team disucssion, the second behavior is expected.

[TachunLin]

Thank you Andy for checking the failure user behavior.
I could verify it again with the successfully upgrade scenario to double confirm the upgrade button would also display with the available upgrade version CR there.