Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jsTruthy flag to constuctor in order to enable JS style truthiness evaluation #257

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

amit777
Copy link
Contributor

@amit777 amit777 commented Oct 7, 2020

This is related to ticket #255

I was not able to make a Chinese translation of the document. Also there are 3 unrelated tests failing that were failing before my changes. Here they are:

3 failing

  1) util/strftime
       Date (Year, Month, Day)
         should format %q as date suffix:

      AssertionError: expected 'th' to equal 'st'
      + expected - actual

      -th
      +st
      
      at Context.<anonymous> (test/unit/util/strftime.ts:40:30)

  2) util/strftime
       Date (Year, Month, Day)
         %j
           should take count of leap years:

      AssertionError: expected '059' to equal '060'
      + expected - actual

      -059
      +060
      
      at Context.<anonymous> (test/unit/util/strftime.ts:29:34)

  3) util/strftime
       Date (Year, Month, Day)
         %j
           should take count of leap years:

      AssertionError: expected '060' to equal '061'
      + expected - actual

      -060
      +061
      
      at Context.<anonymous> (test/unit/util/strftime.ts:33:34)

src/render/boolean.ts Outdated Show resolved Hide resolved
src/render/boolean.ts Outdated Show resolved Hide resolved
src/render/boolean.ts Outdated Show resolved Hide resolved
harttle added a commit that referenced this pull request Oct 8, 2020
@harttle
Copy link
Owner

harttle commented Oct 8, 2020

3 unrelated tests failing that were failing before my changes

Fixed by b11df79

@harttle harttle merged commit f807383 into harttle:master Oct 8, 2020
harttle added a commit that referenced this pull request Oct 8, 2020
harttle pushed a commit that referenced this pull request Oct 8, 2020
# [9.16.0](v9.15.1...v9.16.0) (2020-10-08)

### Features

* support jsTruthy, [#255](#255) [#257](#257) ([72ee7b4](72ee7b4))
@harttle
Copy link
Owner

harttle commented Oct 8, 2020

🎉 This PR is included in version 9.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants