fix: newline_to_br filter should output <br /> instead of <br/>, fixes …

…#320
harttle · Mar 13, 2021 · 9a9b792 · 9a9b792
1 parent 99d14e7
commit 9a9b792
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/builtin/filters/html.ts b/src/builtin/filters/html.ts
@@ -28,7 +28,7 @@ export function escapeOnce (str: string) {
 }
 
 export function newlineToBr (v: string) {
-  return v.replace(/\n/g, '<br/>')
+  return v.replace(/\n/g, '<br />\n')
 }
 
 export function stripHtml (v: string) {

diff --git a/test/e2e/issues.ts b/test/e2e/issues.ts
@@ -1,4 +1,4 @@
-import { Liquid } from '../..'
+import { Liquid } from '../../src/liquid'
 import { Liquid as LiquidUMD } from '../../dist/liquid.browser.umd.js'
 import { expect, use } from 'chai'
 import * as chaiAsPromised from 'chai-as-promised'
@@ -95,4 +95,11 @@ describe('Issues', function () {
     )
     expect(html).to.equal('falsefalse')
   })
+  it('#321 comparison for empty/nil', async () => {
+    const engine = new Liquid()
+    const html = await engine.parseAndRender(
+      `{{ 'a \n b \n c' | newline_to_br | split: '<br />' }}`
+    )
+    expect(html).to.equal('a ,\n b ,\n c')
+  })
 })
diff --git a/test/integration/builtin/filters/html.ts b/test/integration/builtin/filters/html.ts
@@ -26,9 +26,9 @@ describe('filters/html', function () {
               'there\n' +
               '{% endcapture %}' +
               '{{ string_with_newlines | newline_to_br }}'
-      const dst = '<br/>' +
-              'Hello<br/>' +
-              'there<br/>'
+      const dst = '<br />\n' +
+              'Hello<br />\n' +
+              'there<br />\n'
       return test(src, dst)
     })
   })