From 58e5ac058c597884db5518d72f62a6b7841cc32b Mon Sep 17 00:00:00 2001 From: Jonathan Cuthbert Date: Mon, 28 Jul 2014 15:59:31 -0400 Subject: [PATCH 1/2] Wait for CityStore token for all action types `getFlightPriceStore` would need to wait for the `CityStore.dispatchToken` for any action type. --- docs/Dispatcher.md | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/docs/Dispatcher.md b/docs/Dispatcher.md index 740c5e6f1806fa..0d676660ac6027 100644 --- a/docs/Dispatcher.md +++ b/docs/Dispatcher.md @@ -109,17 +109,10 @@ The usage of `waitFor()` can be chained, for example: ``` FlightPriceStore.dispatchToken = flightDispatcher.register(function(payload)) { - switch (payload.actionType) { - case 'country-update': - flightDispatcher.waitFor([CityStore.dispatchToken]); - FlightPriceStore.price = - getFlightPriceStore(CountryStore.country, CityStore.city); - break; - - case 'city-update': - FlightPriceStore.price = - FlightPriceStore(CountryStore.country, CityStore.city); - break; + if (payload.actionType === 'country-update' || payload.actionType === 'city-update') { + flightDispatcher.waitFor([CityStore.dispatchToken]); + FlightPriceStore.price = + getFlightPriceStore(CountryStore.country, CityStore.city); } }); ``` From 09966d5767afd28196bd775c6664d9789a286022 Mon Sep 17 00:00:00 2001 From: Jonathan Cuthbert Date: Tue, 29 Jul 2014 17:32:09 -0400 Subject: [PATCH 2/2] Change if statement back to switch statement Using a switch with a fall through instead of an if statement. Also found an unnecessary right parenthesis. --- docs/Dispatcher.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/Dispatcher.md b/docs/Dispatcher.md index 0d676660ac6027..f1b987099007df 100644 --- a/docs/Dispatcher.md +++ b/docs/Dispatcher.md @@ -108,11 +108,14 @@ The usage of `waitFor()` can be chained, for example: ``` FlightPriceStore.dispatchToken = - flightDispatcher.register(function(payload)) { - if (payload.actionType === 'country-update' || payload.actionType === 'city-update') { - flightDispatcher.waitFor([CityStore.dispatchToken]); - FlightPriceStore.price = - getFlightPriceStore(CountryStore.country, CityStore.city); + flightDispatcher.register(function(payload) { + switch (payload.actionType) { + case 'country-update': + case 'city-update': + flightDispatcher.waitFor([CityStore.dispatchToken]); + FlightPriceStore.price = + getFlightPriceStore(CountryStore.country, CityStore.city); + break; } }); ```