Don't skip orgs #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like you're explicitly removing the org and plugin_setting stables and preventing them from being migrated. Why? The org seems to contain important data in most cases. Removing this rm should fix haron#2. I'm imagining some default org stuff might be setup as part of the migrations when grafana starts. If that's the case, it seems that the best solution would be to change the insert for the org item with id 1 to be an update. I can work on that if you agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like you're explicitly removing the org and plugin_setting tables and preventing them from being migrated. Why? The org seems to contain important data in most cases. Removing this rm should fix #2.
I'm imagining some default org stuff might be setup as part of the migrations when grafana starts. If that's the case, it seems that the best solution would be to change the insert for the org item with id 1 to be an update. I can work on that if you agree.