Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching in matcher.py #63

Closed
woodthom2 opened this issue Nov 7, 2024 · 0 comments · Fixed by #69
Closed

Add batching in matcher.py #63

woodthom2 opened this issue Nov 7, 2024 · 0 comments · Fixed by #69
Labels
bug Something isn't working

Comments

@woodthom2
Copy link
Contributor

Related to issue #56

There is another entry point where the LLM is used which is in matcher.py
-> https://github.com/harmonydata/harmony/blob/main/src/harmony/matching/matcher.py#L131

Please can you allow the batch size to be set in an environment variable BATCH_SIZE. If BATCH_SIZE is not set (either empty or null) then we default to 50.

Please add unit tests. E.g. set batch size to 5 and send 10 items to Harmony, check that they are divided into 2 batches of 5+5? If you can add any new unit tests to the folder that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant