From 85eb3a121869206feecbe48e41b067bfbd95606b Mon Sep 17 00:00:00 2001 From: Federico Spada Date: Sun, 21 Apr 2024 15:15:56 +0200 Subject: [PATCH 1/2] Fixed pcan Unpack error PCANBasic.GetValue() must always return a Tuple with 2 elements, otherwise PcanBus._detect_available_configs() raises a "not enough values to unpack" error at line 718. --- can/interfaces/pcan/basic.py | 1 + 1 file changed, 1 insertion(+) diff --git a/can/interfaces/pcan/basic.py b/can/interfaces/pcan/basic.py index b704ca9bd..2ff517c86 100644 --- a/can/interfaces/pcan/basic.py +++ b/can/interfaces/pcan/basic.py @@ -968,6 +968,7 @@ def GetValue(self, Channel, Parameter): res = self.GetValue(Channel, PCAN_ATTACHED_CHANNELS_COUNT) if TPCANStatus(res[0]) != PCAN_ERROR_OK: return (TPCANStatus(res[0]),) + return TPCANStatus(res[0]), () mybuffer = (TPCANChannelInformation * res[1])() elif ( From 1b1f644876319149969e1534ac7b77f39aa888fc Mon Sep 17 00:00:00 2001 From: Federico Spada Date: Sun, 21 Apr 2024 15:21:20 +0200 Subject: [PATCH 2/2] Fixed typo --- can/interfaces/pcan/basic.py | 1 - 1 file changed, 1 deletion(-) diff --git a/can/interfaces/pcan/basic.py b/can/interfaces/pcan/basic.py index 2ff517c86..4d175c645 100644 --- a/can/interfaces/pcan/basic.py +++ b/can/interfaces/pcan/basic.py @@ -967,7 +967,6 @@ def GetValue(self, Channel, Parameter): elif Parameter == PCAN_ATTACHED_CHANNELS: res = self.GetValue(Channel, PCAN_ATTACHED_CHANNELS_COUNT) if TPCANStatus(res[0]) != PCAN_ERROR_OK: - return (TPCANStatus(res[0]),) return TPCANStatus(res[0]), () mybuffer = (TPCANChannelInformation * res[1])()