Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v0.10 #736

Merged
merged 11 commits into from
Apr 5, 2013
Merged

Node v0.10 #736

merged 11 commits into from
Apr 5, 2013

Conversation

hueniverse
Copy link
Contributor

Closes #651

hueniverse pushed a commit that referenced this pull request Apr 5, 2013
Merge pull request #736 from spumko/v0.17
cdf1953 
Node v0.10
@hueniverse hueniverse merged commit cdf1953 into master Apr 5, 2013
@hueniverse
Copy link
Contributor Author

@wpreul @thegoleffect Got a little trigger hapi after finally emerging from this streams2 brainwash that I had to merge. Please still review!

@hueniverse hueniverse deleted the v0.17 branch April 5, 2013 08:00
@geek
Copy link
Member

geek commented Apr 5, 2013

Looks good. Instead of .peek should it be named .preview and emit a 'data' event?

self.preview.on('data', ...

@hueniverse
Copy link
Contributor Author

I'm ok with preview. Not with data. I don't want to imply this is anything like an old stream. maybe just flip it. preview.on('peek')?

@geek
Copy link
Member

geek commented Apr 5, 2013

That sounds good to me.

@hueniverse
Copy link
Contributor Author

Done.

@thegoleffect
Copy link
Contributor

Looks fine to me. I like the way the streams interface mimics the
consistency of Golang - just inherit, define a _read/_write, and works on
anything expecting a stream. Can't wait to play with it.

On Fri, Apr 5, 2013 at 11:45 AM, Eran Hammer notifications@github.comwrote:

Done.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/736#issuecomment-15973455
.

jmonster pushed a commit to jmonster/hapi that referenced this pull request Feb 10, 2014
Merge pull request hapijs#736 from spumko/v0.17
dde10fa 
Node v0.10
@lock lock bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

node 0.10
3 participants
@hueniverse @geek @thegoleffect