Distributable cache for files #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
hueniverse
pushed a commit
that referenced
this pull request
Feb 10, 2013
Distributable cache for files
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
Distributable cache for files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current HTTP caching for files uses last-modified and an etag based on the ino, size and modified time. The problem with this approach is that both headers end up being inconsistent between nodes on a network.
This branch removes Last-Modified entirely, since it's impossible to make it consistent across nodes without using a networked filesystem.
This branch replaces the old etag with a new one that is a hash of the entire file. That etag is kept in an LRU cache keyed by the filepath, ino, size and mtime. This means that the first time a file is requested after process start or file modification it will not return an etag but will return an etag for every request for that file afterward.