-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting undefined headers on transmit #2352
Comments
First, hapi is only targeting the Joyent distribution of node. This is largely logistical until it is easy to setup travis to test with both distributions. Second, I am not following what's the issue here. The framework doesn't care what you put in headers so just stop setting undefined. What am I missing? |
@hueniverse you can test io.js in travis see http://docs.travis-ci.com/user/build-environment-updates/2015-02-03/#iojs_support |
@AdriVanHoudt already done. |
@hueniverse cool! Didn't notice when the last post was posted sorry. |
@hueniverse I just landed here because (as I've seen a few times now), a plugin is setting a header with value of undefined and the resulting error has no reference to the plugin which makes it VERY hard to debug. Any suggestions on how to best do that? In my case, I was working with a plugin that modified headers so it wasn't hard to figure out which and then search for ".header", but if I'd been changing something at another level, I would have had no idea where to even begin looking. |
We'll need to address it as part of node.js 4.0 release testing. |
I'm not sure of what the policy is re bugs due to fixes in iojs which aren't released yet in node (which may or may not be released soon).
heres one. the transmit module allows undefined headers to be set here https://github.com/hapijs/hapi/blob/master/lib/transmit.js#L250.
related issue for context nodejs/node#450
The text was updated successfully, but these errors were encountered: