Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log cache info when using server method short hand calls #1917

Closed
kpdecker opened this issue Sep 8, 2014 · 2 comments · Fixed by #1919
Closed

Log cache info when using server method short hand calls #1917

kpdecker opened this issue Sep 8, 2014 · 2 comments · Fixed by #1919
Assignees
@hueniverse
Labels
feature New functionality or improvement
Milestone
6.8.0

Comments

@kpdecker
Copy link
Contributor

kpdecker commented Sep 8, 2014

Currently the cacheInfo and report arguments are lost by the string method handler wrapping logic. It would be nice if this info was

  1. Exposed on the responses object
  2. Logged on the request. In particular the response time and cache hit or miss state seem to be quite interesting
@hueniverse
Copy link
Contributor

You don't need cacheInfo

@hueniverse hueniverse self-assigned this Sep 8, 2014
@hueniverse hueniverse added this to the 6.8.0 milestone Sep 8, 2014
@hueniverse hueniverse mentioned this issue Sep 8, 2014
Merged
@geek geek closed this as completed in #1919 Sep 8, 2014
@Marsup Marsup added feature New functionality or improvement and removed request labels Sep 20, 2019
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hueniverse hueniverse

Labels
feature New functionality or improvement
Projects
None yet
Milestone
6.8.0
Development

Successfully merging a pull request may close this issue.

Log method pre string notation hapijs/hapi
3 participants
@hueniverse @kpdecker @Marsup