specify hoek minor version #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should but change it to > the required version. |
|
But how do you know it would work with hoek ~3 ? What do you think about an upper bound- 2.0.0? |
|
sure. not too worried about it. |
|
cool 👍 |
hueniverse
pushed a commit
that referenced
this pull request
Jan 31, 2014
specify hoek minor version
jmonster
pushed a commit
to jmonster/hapi
that referenced
this pull request
Feb 10, 2014
specify hoek minor version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for instance,
hoek.onceis not available for 1.3.0.the problem is when you already have hoek version 1.3.0 in your node_modules, and then you install hapi. Because hapi depends on hoek@1.x.x, npm won't install latest hoek in hapi's node_modules (and we don't want to use latest because in the future this hapi version might not work with the latest hoek).
what do you think?
maybe we should do it for other packages?