Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded-time vs fugit #141

Closed
ahdinosaur opened this issue May 4, 2022 · 1 comment · Fixed by #142
Closed

embedded-time vs fugit #141

ahdinosaur opened this issue May 4, 2022 · 1 comment · Fixed by #142
Labels
help wanted Extra attention is needed topic: api Issues concerning the abstract API type: enhancement New feature or request

Comments

@ahdinosaur
Copy link
Contributor

Hi,

I notice in the stm32-rs hal crates, there seems to be a move towards fugit (and fugit_timer) to replace embedded-time.

In my case, using stm32f7xx-hal, I was able to sort out a newtype wrapper to make stepper happy.

But am wondering, would a pull request to change stepper to replace embedded-time with fugit be welcome?

I'm not sure how this would affect non-embedded users using std::time.

@hannobraun hannobraun added type: enhancement New feature or request help wanted Extra attention is needed topic: api Issues concerning the abstract API labels May 4, 2022
@hannobraun
Copy link
Owner

I'm not following the ecosystem closely these days, so I don't have a clear opinion here. But if you're observing such a trend, I'm happy to trust your judgement. Any trend towards fugit certainly isn't a surprise, given it's newer than embedded-time, and its author is a former(?) user/contributor of embedded-time, as well as a central figure in the Embedded Rust world.

So yes, such a pull request would be welcome.

I'm not sure how this would affect non-embedded users using std::time.

I don't think it will? I'm not aware of any compatibility between embedded-time and std::time, and Stepper itself only supports embedded-time so far.


A note about how this could potentially develop in the future: Given #137, and the probable need to define our own traits to stay up-to-date with the latest versions of everything, this could be an opportunity to support both embedded-time and fugit, by defining appropriate traits and providing implementations.

But I'm fine with only supporting the more popular/promising one. I'm just noting the possibility, if the need should arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed topic: api Issues concerning the abstract API type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants