Improve proc macro model
#655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Thank you, @gabsi26, looks great!
(Side note: the arguments can refer to each other in their
min/maxattributes, this is due to the order of the generated code.
I think this is a nice feature and should be kept.)
I fully agree!
If an argument has no annotations it now does not require an attribute Signed-off-by: gabsi26 <gabriel.seebach@gmx.at>
Signed-off-by: gabsi26 <gabriel.seebach@gmx.at>
hannobraun
force-pushed
the
improve_proc_macro
branch
from
a671aa8 to
1ffc086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make argument annotation optional and use macro for all example models.
(Side note: the arguments can refer to each other in their
min/maxattributes, this is due to the order of the generated code.I think this is a nice feature and should be kept.)