Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo redo minor refactor #650

Merged
merged 2 commits into from
Apr 26, 2021
Merged

undo redo minor refactor #650

merged 2 commits into from
Apr 26, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Apr 22, 2021

Context

Refactored undo-redo code not to use big if-else statement.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@e055cba). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #650   +/-   ##
==========================================
  Coverage           ?   92.51%           
==========================================
  Files              ?      164           
  Lines              ?    38591           
  Branches           ?     5342           
==========================================
  Hits               ?    35701           
  Misses             ?     2884           
  Partials           ?        6           

Copy link
Contributor

@wojciechczerniak wojciechczerniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@izulin izulin merged commit c223cd0 into develop Apr 26, 2021
@izulin izulin deleted the pu/undoredorefactor branch April 26, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants