Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scoped Named Expressions bugfix #647

Merged
merged 7 commits into from
Apr 26, 2021
Merged

scoped Named Expressions bugfix #647

merged 7 commits into from
Apr 26, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Apr 22, 2021

Context

Fixes #641. Fixes #646.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. removal of scoped named expressions #641
  2. undo + scoped named expression #646

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #647 (0b6ff87) into develop (c223cd0) will decrease coverage by 0.00%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #647      +/-   ##
===========================================
- Coverage    92.51%   92.50%   -0.01%     
===========================================
  Files          164      164              
  Lines        38591    38618      +27     
  Branches      5342     5355      +13     
===========================================
+ Hits         35701    35724      +23     
- Misses        2884     2888       +4     
  Partials         6        6              
Impacted Files Coverage Δ
src/UndoRedo.ts 98.71% <60.00%> (-0.26%) ⬇️
src/NamedExpressions.ts 94.91% <93.61%> (-0.77%) ⬇️
src/CrudOperations.ts 86.30% <100.00%> (ø)
src/HyperFormula.ts 99.00% <100.00%> (+<0.01%) ⬆️
src/Operations.ts 91.17% <100.00%> (+0.01%) ⬆️
src/parser/ColumnAddress.ts 93.63% <0.00%> (ø)
src/parser/addressRepresentationConverters.ts 88.32% <0.00%> (+0.50%) ⬆️

@izulin izulin changed the title Pu/scoped ne scoped Named Expressions bugfix Apr 22, 2021
* scope for listing named expressions

* minor fix

* doc
@izulin izulin merged commit 80e7f98 into develop Apr 26, 2021
@izulin izulin deleted the pu/scopedNE branch April 26, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants