Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start off with writing a guide #271

Closed
wants to merge 4 commits into from
Closed

Conversation

scarletfog
Copy link
Contributor

Context

Start working on the guide pages.

@wojciechczerniak I have several questions:
-Should we mention operating system in the requirements? I've seen some guides having that but I am not convinced it applies in HF 🤔
-Should I contact @aninde for the "browser support"?
-Does the structure in basic-use make sense to you?

@scarletfog scarletfog self-assigned this Mar 25, 2020
@wojciechczerniak
Copy link
Contributor

-Should we mention operating system in the requirements? I've seen some guides having that but I am not convinced it applies in HF 🤔

No. The operating system doesn't matter. Node version, web browser compatibility, GPU support, browser features like Intl (Node full-ICU, therefore v13 is the required version). We may mention that the lower Node version is possible but it requires a full-ICU build or external package. No point in mentioning LTS. And we can't go lower than v10 because of gpu.js

-Should I contact @aninde for the "browser support"?

Evergreen browsers, last 2 releases. That's all.

We will test it in Internet Explorer 9, 10 and 11 but currently, it's not possible. We're waiting for @swistach and #219. So we may add something later.

-Does the structure in basic-use make sense to you?

Yes. I would add getCellFormula and getCellValue. Some descriptions to build* sections to explain what are the differences. Basically, this is an extended version of what we've did for the readme.md

@wojciechczerniak wojciechczerniak removed their request for review April 5, 2020 23:18
@scarletfog
Copy link
Contributor Author

The topic was moved to be worked on in gitbook. I will close this PR for now.

@scarletfog scarletfog closed this Apr 9, 2020
@scarletfog scarletfog deleted the documentation/issue-149 branch August 6, 2020 13:15
@scarletfog scarletfog restored the documentation/issue-149 branch August 6, 2020 13:15
@wojciechczerniak wojciechczerniak deleted the documentation/issue-149 branch September 15, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants