language with factory #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciechczerniak
suggested changes
Mar 19, 2020
src/BuildEngineFromArraysFactory.ts
Outdated
| @@ -66,6 +66,9 @@ export class BuildEngineFromArraysFactory { | |||
| } | |||
|
|
|||
| public buildFromSheet(sheet: Sheet, configInput?: Partial<ConfigParams>): HyperFormula { | |||
| return this.buildFromSheets({Sheet1: sheet}, configInput) | |||
| const newsheetprefix = new Config(configInput).language.interface.NEW_SHEET_PREFIX + '1' | |||
There was a problem hiding this comment.
Hmm 🤔 We're digging deep. Maybe within #36 we could introduce a method getTranslation('interface.NEW_SHEET_PREFIX') to be sure the getter is unit tested correctly and we have fallbacks in place.
Right now I see here possible three null exceptions
Co-Authored-By: Wojciech Czerniak <wojciech.czerniak@gmail.com>
wojciechczerniak
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Creating engine from single array under different language should result in different naming.
How has this been tested?
Types of changes
Related issue(s):
Checklist: