Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug with order of evaluation and caching #735

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Jun 27, 2021

Context

Fixes a very subtle bug with caching.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@codecov
Copy link

codecov bot commented Jun 27, 2021

Codecov Report

Merging #735 (4d7552e) into develop (2390b62) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #735      +/-   ##
===========================================
- Coverage    92.15%   92.15%   -0.01%     
===========================================
  Files          166      166              
  Lines        39689    39693       +4     
  Branches      3615     3616       +1     
===========================================
+ Hits         36577    36579       +2     
- Misses        3106     3108       +2     
  Partials         6        6              
Impacted Files Coverage Δ
src/interpreter/plugin/NumericAggregationPlugin.ts 91.94% <66.66%> (-0.24%) ⬇️

@izulin izulin merged commit 03a1066 into develop Jun 28, 2021
@izulin izulin deleted the pu/cachingerror branch June 28, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants