Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor of matrices #652

Merged
merged 21 commits into from
May 14, 2021
Merged

refactor of matrices #652

merged 21 commits into from
May 14, 2021

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Apr 24, 2021

Context

Removal of deprecated {=FORMULA} notation. Now it should be integrated into regular formulas, which should be able to return arrays instead of just scalars.

Also, fixes issue #651

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 24, 2021

This pull request introduces 4 alerts and fixes 2 when merging e19d9db into afd9919 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@b5115dc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 580f447 differs from pull request most recent head 5cb0e6a. Consider uploading reports for the commit 5cb0e6a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #652   +/-   ##
==========================================
  Coverage           ?   92.42%           
==========================================
  Files              ?      166           
  Lines              ?    38859           
  Branches           ?     3548           
==========================================
  Hits               ?    35915           
  Misses             ?     2938           
  Partials           ?        6           

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 24, 2021

This pull request introduces 4 alerts and fixes 2 when merging 920074f into afd9919 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 26, 2021

This pull request introduces 4 alerts and fixes 2 when merging 58820f3 into c223cd0 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@izulin izulin changed the title refactor of matrices WIP: refactor of matrices Apr 26, 2021
@izulin izulin changed the title WIP: refactor of matrices refactor of matrices Apr 26, 2021
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 26, 2021

This pull request introduces 4 alerts and fixes 2 when merging b5a2ed9 into 80e7f98 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@izulin izulin marked this pull request as draft April 27, 2021 21:15
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Apr 27, 2021

This pull request introduces 4 alerts and fixes 2 when merging 38926b1 into cf800ce - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@izulin izulin mentioned this pull request May 7, 2021
7 tasks
@izulin izulin marked this pull request as ready for review May 7, 2021 20:53
@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 4 alerts and fixes 2 when merging be1b7ed into 0eb13b2 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 4 alerts and fixes 2 when merging 75ebaf5 into aa1e4d1 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 4 alerts and fixes 2 when merging ea58825 into 0bb0dbe - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 7 alerts and fixes 2 when merging 12cbe79 into 0b1b074 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 2 for Assignment to constant
  • 1 for Useless assignment to local variable

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 4 alerts and fixes 2 when merging 580f447 into 0b1b074 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link
Contributor

lgtm-com bot commented May 14, 2021

This pull request introduces 4 alerts and fixes 2 when merging 5cb0e6a into b5115dc - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@izulin izulin merged commit e624cc3 into develop May 14, 2021
@izulin izulin deleted the pu/oldmatrixnotation branch May 14, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants