Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu.js is listed as required dependency #642

Closed
wojciechczerniak opened this issue Apr 21, 2021 · 1 comment · Fixed by #644
Closed

gpu.js is listed as required dependency #642

wojciechczerniak opened this issue Apr 21, 2021 · 1 comment · Fixed by #644
Labels
Bug Something isn't working

Comments

@wojciechczerniak
Copy link
Contributor

Description

GPU.js is no longer a required dependency, so this entry is wrong:

hyperformula/package.json

Line 145 in 6ec629b

"gpu.js": "2.3.0",

We should move it to peer/optional deps

Your environment

  • HyperFormula version: 0.5.0
  • Browser Name and version: Node
  • Operating System: OS X, Linux
@wojciechczerniak wojciechczerniak added the Bug Something isn't working label Apr 21, 2021
@jansiegel jansiegel mentioned this issue Apr 21, 2021
Merged
7 tasks
@jansiegel jansiegel linked a pull request Apr 21, 2021 that will close this issue
Move GPU.js to devDependencies and add it to optionalDependencies. #644
Merged
7 tasks
@wojciechczerniak
Copy link
Contributor Author

Done in #644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move GPU.js to devDependencies and add it to optionalDependencies. handsontable/hyperformula
1 participant
@wojciechczerniak