Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pu/inftybinsearch #562

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Pu/inftybinsearch #562

merged 4 commits into from
Nov 4, 2020

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Nov 4, 2020

Context

Fixes problem with HLOOKUP/VLOOKUP on sorted data with column/row ranges.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. VLOOKUP on column ranges #559

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@izulin izulin requested a review from bardek8 November 4, 2020 12:16
@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #562 into develop will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
- Coverage    91.90%   91.90%   -0.01%     
===========================================
  Files          161      161              
  Lines        33487    33492       +5     
  Branches      3130     3131       +1     
===========================================
+ Hits         30777    30781       +4     
- Misses        2704     2705       +1     
  Partials         6        6              
Impacted Files Coverage Δ
src/interpreter/binarySearch.ts 85.89% <83.33%> (-0.41%) ⬇️
src/AbsoluteCellRange.ts 87.16% <100.00%> (ø)

Copy link
Collaborator

@bardek8 bardek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@izulin izulin merged commit 8c237d2 into develop Nov 4, 2020
@izulin izulin deleted the pu/inftybinsearch branch November 4, 2020 22:14
@izulin izulin mentioned this pull request Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants