Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pu/aggregation fix #515

Merged
merged 25 commits into from
Sep 18, 2020
Merged

Pu/aggregation fix #515

merged 25 commits into from
Sep 18, 2020

Conversation

izulin
Copy link
Collaborator

@izulin izulin commented Sep 17, 2020

Context

Numeric aggregation plugin was in a bad need for a refactor.
Reworked implementation captures the nuance of when values are coerced (mostly: when explicitly as a value-argument), and when are ignored when of wrong type (when passed as a reference or part of a range). Error propagation is also subtle: some functions ignore errors: COUNT, COUNTA.
Also, strings are coerced in a special way: string becomes always just a 0 (when passed as a part of a range/reference).

This PR also fixes handling of empty arguments in numeric aggregation functions (and in function MEDIAN).

How has this been tested?

See added tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. Trailing commas #490

Checklist:

  • My code follows the code style of this project,
  • My change requires a change to the documentation,
  • I described the modification in the CHANGELOG.md file.

@izulin izulin changed the base branch from master to develop September 17, 2020 20:36
Copy link
Collaborator

@voodoo11 voodoo11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@izulin izulin merged commit 22ae2d7 into develop Sep 18, 2020
@izulin izulin deleted the pu/aggregation-fix branch September 18, 2020 11:54
@wojciechczerniak wojciechczerniak mentioned this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants