Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track cell type better #313

Closed
wojciechczerniak opened this issue Apr 21, 2020 · 2 comments
Closed

Track cell type better #313

wojciechczerniak opened this issue Apr 21, 2020 · 2 comments
Assignees
Labels
Feature Something we can add later on without introducing a breaking change To Be Discussed Extra attention is needed Verified Verified by Handsoncode
Milestone

Comments

@wojciechczerniak
Copy link
Contributor

wojciechczerniak commented Apr 21, 2020

Description

Currently, after calculations that are including date and time, we have no way to figure out how we should format the final output. We will get number as a value. This hides the meaning from the end-user. Most of the spreadsheet apps are tracking the operations and can format the value correctly. We can format the value on display, but we need the information about the value type. Current CellType returned by the public API method is limited:

hyperformula/src/Cell.ts

Lines 60 to 66 in 1f11e07

export enum CellValueType {
EMPTY = 'EMPTY',
NUMBER = 'NUMBER',
STRING = 'STRING',
BOOLEAN = 'BOOLEAN',
ERROR = 'ERROR',
}

Date, Time and DateTime Logic

We can use this source [1] as a reference how to handle ops. But we should compare it with other spreadsheet apps
obraz

Functions

Some functions are more or less easy: =DATE() returns a date.

Links

[1] https://help.libreoffice.org/6.4/en-US/text/shared/01/05020301.html

@wojciechczerniak wojciechczerniak added Integration Feature Something we can add later on without introducing a breaking change labels Apr 21, 2020
@wojciechczerniak wojciechczerniak added this to the April 2020 milestone Apr 22, 2020
@izulin izulin self-assigned this Apr 22, 2020
@wojciechczerniak wojciechczerniak added the To Be Discussed Extra attention is needed label May 22, 2020
@wojciechczerniak wojciechczerniak modified the milestones: April 2020, Next May 22, 2020
@krzysztofspilka krzysztofspilka added the Verified Verified by Handsoncode label Jun 23, 2020
@wojciechczerniak
Copy link
Contributor Author

At today's meeting with @krzysztofspilka and @bardek8 we've decided that this feature has to wait for more use case scenarios. ATM it's considered a niche and we will focus on other features.

Moving to Backlog.

@wojciechczerniak wojciechczerniak modified the milestones: Next, December 2020 Nov 25, 2020
@izulin izulin self-assigned this Dec 17, 2020
@izulin izulin mentioned this issue Dec 29, 2020
7 tasks
@wojciechczerniak
Copy link
Contributor Author

Done in #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Something we can add later on without introducing a breaking change To Be Discussed Extra attention is needed Verified Verified by Handsoncode
Projects
None yet
Development

No branches or pull requests

3 participants