Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name for a new Sheet1 is hardcoded in buildFromSheet method #254

Closed
wojciechczerniak opened this issue Mar 16, 2020 · 1 comment
Closed
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@wojciechczerniak
Copy link
Contributor

Description

The name of the auto-generated sheet should be Arkusz1 if the language was set to PL.

public buildFromSheet(sheet: Sheet, config: Config = new Config()): HyperFormula {
return this.buildFromSheets({Sheet1: sheet}, config)
}

Steps to reproduce

const engine = HyperFormula.buildFromArray([[ ... ]], { language: plPL })

expect(engine.getSheetName(0)).toEqual('Arkusz1')

or

  it('#buildFromSheet adds default sheet Arkusz1 when language is set to plPL', () => {
    const config = new Config({language: plPL })
    const engine = HyperFormula.buildFromArray([], config)

    expect(engine.getAllSheetsDimensions()).toEqual({'Arkusz1': {'height': 0, 'width': 0}})
  })
@wojciechczerniak wojciechczerniak added the Bug Something isn't working label Mar 16, 2020
@wojciechczerniak wojciechczerniak added this to the March 2020 milestone Mar 16, 2020
@izulin izulin self-assigned this Mar 18, 2020
@izulin izulin mentioned this issue Mar 19, 2020
7 tasks
@wojciechczerniak
Copy link
Contributor Author

Done in #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants