Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test runner for web browsers #219

Closed
3 tasks
wojciechczerniak opened this issue Feb 28, 2020 · 4 comments
Closed
3 tasks

Test runner for web browsers #219

wojciechczerniak opened this issue Feb 28, 2020 · 4 comments
Labels
Chore Devops and scripting. Tasks that are not changing the product Feature Something we can add later on without introducing a breaking change
Milestone

Comments

@wojciechczerniak
Copy link
Contributor

wojciechczerniak commented Feb 28, 2020

Description

Currently, all tests are run or Node and we don't know if all V8 features ale supported in the web browsers and which ones. We need a way to run tests in the desktop and mobile web browsers: Chrome, Firefox, Safari, Opera, Edge etc.

  • Generate web HTML runner
  • Generate mobile HTML runner
  • Add CI to runt tests in Puppeteer: Chrome + Firefox
@wojciechczerniak wojciechczerniak added the Feature Something we can add later on without introducing a breaking change label Feb 28, 2020
@wojciechczerniak wojciechczerniak added this to the March 2020 milestone Feb 28, 2020
@wojciechczerniak wojciechczerniak added the Chore Devops and scripting. Tasks that are not changing the product label Feb 28, 2020
@wojciechczerniak wojciechczerniak mentioned this issue Feb 28, 2020
89 tasks
@mrpiotr-dev mrpiotr-dev mentioned this issue Mar 8, 2020
4 tasks
@aninde
Copy link
Contributor

aninde commented Mar 20, 2020

I would like to run tests on as many browsers as possible in the latest versions in accordance with #1 (comment) i.e.

Operating system: Windows
Browsers:

  • IE 9?
  • IE 10
  • IE 11
  • Edge
  • Chrome
  • Firefox

Operating system: macOS
Browsers:

  • Chrome
  • Safari
  • Edge
  • Firefox
  • Opera

Mobile: Operating system Android

  • Browser: Chrome, Firefox?

Mobile Operating system iOs:

  • Browser: Safari
  • Ipad? operation system: iOs Browser Safari

A major update of the iOs system is planned for the summer 2020. Maybe this will be delayed by the current situation.

@mrpiotr-dev mrpiotr-dev mentioned this issue Apr 11, 2020
2 tasks
mrpiotr-dev added a commit that referenced this issue Apr 13, 2020
mrpiotr-dev added a commit that referenced this issue Apr 18, 2020
mrpiotr-dev added a commit that referenced this issue Apr 18, 2020
@wojciechczerniak
Copy link
Contributor Author

After #298 we've came with @budnix and @swistach to a conclusion that maintaining three testing frameworks and mocking Jest with Jasmine may not be the best idea. There are some compatibility issues and mocking the differences breaks the stability of the tests.

  • Ditch Jest in favor of Jasmine for testing in multiple environments
  • Have a nice reporter for Node and web browsers
  • Have localhost server for manual testing on mobile devices
  • Run Karma/Puppeteer with headless Chrome and Firefox for CI

mrpiotr-dev added a commit that referenced this issue Apr 27, 2020
mrpiotr-dev added a commit that referenced this issue Apr 27, 2020
mrpiotr-dev added a commit that referenced this issue Apr 27, 2020
wojciechczerniak pushed a commit that referenced this issue Apr 29, 2020
* #219 - Adds the initial configuration to run tests in browser
* #219 - A tiny cleanup in test:browser changes
* #219 - Adds missing entry in a eslintignore file
* #219 - Adjustments in 140+ specs to be able to run tests in browsers
* #219 - Adds missing matcher toMatchObject
* #219 - Removes unnecessary devDep
* #219 - Solves 'jest.spyOn/jest.fn' problems by using SinonJS. Adds a new devDependency: sinon
* #219 - Removes unnecessary dependencies
* #219 - Adjusts test to run them in browsers
* #219 - Adds Karma's configuration for FF and Chrome. Adds experimental CI action
* #219 - Adds xvfb to the action
* #219 - Reverts experimental changes for catching license's console.warn
* #219 - Adds additional reporter to the karma's configuration
* 1 test
* 2nd error
* regexps
* regexp 2
* #219 - Adds config generator for karma. Uses headless browsers as a default on CI.
* #219 - Missing adjustments to the linter's config
* proper init testing
* removed faulty test
* smarter validation
* #219 - Removes jest and jest-related configuration, sinon 😢 and uses jasmine instead
* #219 - revert jasmine-related files into .js
* #219 - Changes default spy strategy for jasmine
* #219 - Corrects gh's action name
* #219 - Sets karma.browsers configuration
* #219 - Adjusts changes before CR
* #219 - Adds custom matcher to be compatible with jest implementation (more or less)
* #219 - Removes unnecessary code from a test's bootstrap file
* #219 - Removes unnecessary code from a custom matcher's  file
* #219 - Removes unnecessary indent from a custom matcher's file
* #219 - Adjusts most recent changes in config's test file to the new - jasmine-based env
* #219 - Adjusts custom matchers and *.MD files

Co-authored-by: Przemek <przemek@navalgo.com>
@wojciechczerniak
Copy link
Contributor Author

wojciechczerniak commented Apr 29, 2020

Note: As a part of this issue @swistach is going to refactor LicenseKey tests so only one is for console.warn call, the rest (because the warning is shown only once) will be tested with hfInstance.config.licenseValidityState

Almost done in #298

wojciechczerniak added a commit that referenced this issue May 4, 2020
* #219 - Adjusts licenseKeyValidator's tests to run it in jasmine
* #219 - Post CR changes and adjustments to not expose protected config
* #219 - Reverts getConfig() type for Config
* Update src/HyperFormula.ts

Co-authored-by: Wojciech Czerniak <wojciech.czerniak@gmail.com>
mrpiotr-dev added a commit that referenced this issue May 11, 2020
wojciechczerniak pushed a commit that referenced this issue May 11, 2020
* #219 Downgrades karma to v4 to add support for *.ts files
* #219 - Removes unnecessary devDep
* #219 - Upgrades karma to v5 to fix vulnerability
@wojciechczerniak
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Devops and scripting. Tasks that are not changing the product Feature Something we can add later on without introducing a breaking change
Projects
None yet
Development

No branches or pull requests

3 participants