Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: simpleCellAddressFromString crashes when called with non-ASCII character on an unquoted sheet name #1312

Closed
sequba opened this issue Sep 26, 2023 · 1 comment · Fixed by #1314
Closed

[Bug]: simpleCellAddressFromString crashes when called with non-ASCII character on an unquoted sheet name #1312

sequba opened this issue Sep 26, 2023 · 1 comment · Fixed by #1314
Assignees
@sequba
Labels
API Public methods and properties Bug Something isn't working Impact: Medium Released

Comments

@sequba
Copy link
Contributor

sequba commented Sep 26, 2023 •
edited
Loading

Description

The sheet names with non-ASCII characters must be enclosed in single quotes. But when they aren't simpleCellAddressFromString should return undefined (as for invalid cell reference). Currently it crashes with error

TypeError: Cannot read properties of null (reading '6')

Related: #1313

Originally reported by a user in HOT forum: https://forum.handsontable.com/t/hyperformula-named-expressions-using-japanese-unicode-characters/7126

Video or screenshots

image

Demo

https://codesandbox.io/s/happy-matan-j298f2?file=/src/data.js

HyperFormula version

2.6.0

Your framework

No response

Your environment

Codesandbox
@sequba sequba self-assigned this Sep 26, 2023
@sequba sequba added API Public methods and properties Impact: Medium labels Sep 26, 2023
This was referenced Sep 26, 2023
Open
Merged
@sequba sequba linked a pull request Sep 26, 2023 that will close this issue
Fix simpleCellAddressFromString crashes when called with non-ASCII character on an unquoted sheet name #1314
Merged
16 tasks
@sequba sequba added the Bug Something isn't working label Nov 29, 2023
@AMBudnik
Copy link
Contributor

Closed as solved and released in HyperFormula 2.6.1.
List of all the changes https://github.com/handsontable/hyperformula/releases/tag/2.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sequba sequba

Labels
API Public methods and properties Bug Something isn't working Impact: Medium Released
Projects
None yet
Milestone
No milestone
2 participants
@sequba @AMBudnik