-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Formula helpers and named expressions (part 2) (#192)
* Add test for 255-long named expression * Add more validations for named expressions * Export ExportedCellChange object instead of class Because in a moment I will introduce second class, representing changed named expression. * It no longer exports only values * Don't leak internal detail of workbook named expressions, -1 sheet * Add tests for named expression changes * Added test for matrix formula without braces * Add tests for errors in named expressions with something other than formula * lint-fix * Add ability to calculate fire-and-forget formulas * Refactor common part * lint-fix * Add documentation * Fix tests * Make it more clear what is the reason we initialize -1 sheet * Add possibility to calculateFormula in context of some sheet * Rename spec * Change the test other way around * Support any raw cell content as an expression * Refactoring: Rename NamedExpressions#storeFormulaInCell -> #storeExpressionInCell * Refactoring: Rename #changeNamedExpressionFormula -> #changeNamedExpressionExpression * Support other types of input when changing named expressions * Refactoring: change naming external formula to temporary formula Since formula is not stored, temporary sounds better * Refactoring: Make HyperFormula know less not directly know that named expression is stored in some specific cell. * lint-fix
- Loading branch information
Showing
22 changed files
with
504 additions
and
215 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
import {ContentChanges} from './ContentChanges' | ||
import {InternalCellValue, SimpleCellAddress} from './Cell' | ||
import {Ast} from './parser' | ||
import {Vertex} from './DependencyGraph' | ||
|
||
export interface Evaluator { | ||
run(): void, | ||
partialRun(vertices: Vertex[]): ContentChanges, | ||
runAndForget(ast: Ast, address: SimpleCellAddress): InternalCellValue, | ||
destroy(): void, | ||
} |
Oops, something went wrong.