From 989cbc2321f1a881470dc01a46615278df157467 Mon Sep 17 00:00:00 2001 From: Piotr Laszczkowski Date: Mon, 27 Apr 2020 19:43:58 +0200 Subject: [PATCH] #219 - Adjusts changes before CR --- .config/karma/debug.js | 2 +- .eslintignore | 2 +- Makefile | 2 +- test/_setupFiles/bootstrap.ts | 2 +- test/_setupFiles/jsdom.js | 1 + test/interpreter/coercions.spec.ts | 8 ++------ 6 files changed, 7 insertions(+), 10 deletions(-) diff --git a/.config/karma/debug.js b/.config/karma/debug.js index 8e3fe05bab..cd28cf29ca 100644 --- a/.config/karma/debug.js +++ b/.config/karma/debug.js @@ -9,4 +9,4 @@ module.exports.create = function(config) { reporters: ['kjhtml'], singleRun: false, } -} \ No newline at end of file +} diff --git a/.eslintignore b/.eslintignore index f0b01135cd..4bbf2e821a 100644 --- a/.eslintignore +++ b/.eslintignore @@ -16,4 +16,4 @@ lib script test-jasmine typings -test/_setupFiles/*.js \ No newline at end of file +test/_setupFiles/*.js diff --git a/Makefile b/Makefile index 82f870d7d4..ae948f60f1 100644 --- a/Makefile +++ b/Makefile @@ -11,7 +11,7 @@ test: ## Run tests @npm run test test-ci: ## Separate test configuration for CI environment - @npm run test:ci + @npm run test check: typecheck test ## Check whether code is working correctly (types + specs) diff --git a/test/_setupFiles/bootstrap.ts b/test/_setupFiles/bootstrap.ts index 7b5f61b3e4..f3a95cbb32 100644 --- a/test/_setupFiles/bootstrap.ts +++ b/test/_setupFiles/bootstrap.ts @@ -65,4 +65,4 @@ beforeAll(() => { } }, }) -}) \ No newline at end of file +}) diff --git a/test/_setupFiles/jsdom.js b/test/_setupFiles/jsdom.js index f5324d4f7d..ff27ae2b65 100644 --- a/test/_setupFiles/jsdom.js +++ b/test/_setupFiles/jsdom.js @@ -1,6 +1,7 @@ import { JSDOM } from 'jsdom' const dom = new JSDOM('') + global.document = dom.window.document global.window = dom.window global.navigator = dom.window.navigator diff --git a/test/interpreter/coercions.spec.ts b/test/interpreter/coercions.spec.ts index bd574f9a38..f2c89acc43 100644 --- a/test/interpreter/coercions.spec.ts +++ b/test/interpreter/coercions.spec.ts @@ -41,12 +41,8 @@ describe('#coerceBooleanToNumber', () => { const dateHelper = new DateTimeHelper(config) const numberLiteralsHelper = new NumberLiteralHelper(config) const arithmeticHelper = new ArithmeticHelper(config, dateHelper, numberLiteralsHelper) - // eslint-disable-next-line @typescript-eslint/ban-ts-ignore - // @ts-ignore - expect(coerceBooleanToNumber(true)).toBe(arithmeticHelper.coerceScalarToNumberOrError(true)) - // eslint-disable-next-line @typescript-eslint/ban-ts-ignore - // @ts-ignore - expect(coerceBooleanToNumber(false)).toBe(arithmeticHelper.coerceScalarToNumberOrError(false)) + expect(coerceBooleanToNumber(true)).toBe(arithmeticHelper.coerceScalarToNumberOrError(true) as number) + expect(coerceBooleanToNumber(false)).toBe(arithmeticHelper.coerceScalarToNumberOrError(false) as number) }) })