Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql.js shouldn't be referenced when using sqlite3 client #18

Closed
haltcase opened this issue Jan 16, 2017 · 2 comments
Closed

sql.js shouldn't be referenced when using sqlite3 client #18

haltcase opened this issue Jan 16, 2017 · 2 comments
Labels
good first issue Probably good for a user's first contribution. type: bug Something isn't working as intended or expected.
Milestone
v1.0.0-rc.2

Comments

@haltcase
Copy link
Owner

Reference #17 where this was uncovered.
@haltcase haltcase added the type: bug Something isn't working as intended or expected. label Jan 16, 2017
@haltcase haltcase added this to the v1.0.0-rc.2 milestone Jan 16, 2017
@haltcase haltcase added the good first issue Probably good for a user's first contribution. label Jan 16, 2017
@haltcase
Copy link
Owner Author

haltcase commented Jan 16, 2017 •
edited
Loading

Should just be able to move this line down into the readDatabase function and change it to a require. That way the module is only imported when sql.js has been set as the client.

Easy PR for anyone looking for some contributor karma 😜 Otherwise I'll fix this up tonight after work.

@haltcase
Copy link
Owner Author

Fixed in v1.0.0-rc.2. Thanks @vladshcherbin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Probably good for a user's first contribution. type: bug Something isn't working as intended or expected.
Projects
None yet
Milestone
v1.0.0-rc.2
Development

No branches or pull requests
1 participant
@haltcase