From be9194c4931b9828c16257e5ee5e427bd67cc83d Mon Sep 17 00:00:00 2001
From: Ryan Wang <i@ryanc.cc>
Date: Tue, 21 Feb 2023 17:28:57 +0800
Subject: [PATCH] refactor: support configure when plugin is stopped

---
 .../api-client/src/models/plugin-status.ts    | 20 ++++++-------------
 .../plugins/components/PluginListItem.vue     |  9 ++++++++-
 .../system/plugins/layouts/PluginLayout.vue   |  6 ++----
 3 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/packages/api-client/src/models/plugin-status.ts b/packages/api-client/src/models/plugin-status.ts
index dca435a50..b32abd1bf 100644
--- a/packages/api-client/src/models/plugin-status.ts
+++ b/packages/api-client/src/models/plugin-status.ts
@@ -12,6 +12,10 @@
  * Do not edit the class manually.
  */
 
+// May contain unused imports in some cases
+// @ts-ignore
+import { Condition } from './condition'
+
 /**
  *
  * @export
@@ -26,28 +30,16 @@ export interface PluginStatus {
   phase?: PluginStatusPhaseEnum
   /**
    *
-   * @type {string}
-   * @memberof PluginStatus
-   */
-  reason?: string
-  /**
-   *
-   * @type {string}
+   * @type {Array<Condition>}
    * @memberof PluginStatus
    */
-  message?: string
+  conditions?: Array<Condition>
   /**
    *
    * @type {string}
    * @memberof PluginStatus
    */
   lastStartTime?: string
-  /**
-   *
-   * @type {string}
-   * @memberof PluginStatus
-   */
-  lastTransitionTime?: string
   /**
    *
    * @type {string}
diff --git a/src/modules/system/plugins/components/PluginListItem.vue b/src/modules/system/plugins/components/PluginListItem.vue
index a8371a0c4..e05a7af07 100644
--- a/src/modules/system/plugins/components/PluginListItem.vue
+++ b/src/modules/system/plugins/components/PluginListItem.vue
@@ -66,6 +66,13 @@ const handleResetSettingConfig = async () => {
     },
   });
 };
+
+const getFailedMessage = (plugin: Plugin) => {
+  if (plugin.status?.conditions?.length) {
+    const lastCondition = plugin.status.conditions[0];
+    return [lastCondition.reason, lastCondition.message].join(":");
+  }
+};
 </script>
 <template>
   <PluginUploadModal
@@ -105,7 +112,7 @@ const handleResetSettingConfig = async () => {
       <VEntityField v-if="plugin?.status?.phase === 'FAILED'">
         <template #description>
           <VStatusDot
-            v-tooltip="`${plugin?.status?.reason}:${plugin?.status?.message}`"
+            v-tooltip="getFailedMessage(plugin)"
             state="error"
             animate
           />
diff --git a/src/modules/system/plugins/layouts/PluginLayout.vue b/src/modules/system/plugins/layouts/PluginLayout.vue
index 57cd0089b..9bc0fbb96 100644
--- a/src/modules/system/plugins/layouts/PluginLayout.vue
+++ b/src/modules/system/plugins/layouts/PluginLayout.vue
@@ -70,7 +70,7 @@ const handleFetchPlugin = async () => {
 };
 
 const handleFetchSettings = async () => {
-  if (!plugin.value) return;
+  if (!plugin.value || !plugin.value.spec.settingName) return;
   const { data } = await apiClient.plugin.fetchPluginSetting({
     name: plugin.value?.metadata.name,
   });
@@ -112,9 +112,7 @@ onMounted(async () => {
     return;
   }
 
-  if (isStarted.value) {
-    await handleFetchSettings();
-  }
+  await handleFetchSettings();
 
   tabs.value = cloneDeep(initialTabs);