Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x86] Codegen should split up double saturating-narrows #7069

Closed
rootjalex opened this issue Oct 5, 2022 · 1 comment · Fixed by #7280
Closed

[x86] Codegen should split up double saturating-narrows #7069

rootjalex opened this issue Oct 5, 2022 · 1 comment · Fixed by #7280
Assignees
@rootjalex
Labels
performance

Comments

@rootjalex
Copy link
Member

CodeGen_ARM already does this (see here).

x86's options are far more limited (only i32 -> u8 and i32 -> i8 are possible), but a pair of saturating narrow instructions will be better than what we currently generate. Other backends might also benefit from this, but I haven't looked into it.
@rootjalex rootjalex self-assigned this Oct 5, 2022
@rootjalex
Copy link
Member Author

Looks like Hexagon also already splits these up, but WASM doesn't yet (can also only do i32 -> u8 and i32 -> i8).

@rootjalex rootjalex mentioned this issue Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootjalex rootjalex

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[x86 & wasm] Split up double saturating-narrows from i32 halide/Halide
1 participant
@rootjalex