From 5de771f1e32d126559d848ec5331238aa741ea6e Mon Sep 17 00:00:00 2001 From: Dan King Date: Thu, 13 Jul 2023 12:20:25 -0400 Subject: [PATCH 1/2] [query] skip combiner tests until combiner is fast in QoB --- hail/python/test/hail/vds/test_combiner.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hail/python/test/hail/vds/test_combiner.py b/hail/python/test/hail/vds/test_combiner.py index 1b4e4726ff2..151ebb6c62e 100644 --- a/hail/python/test/hail/vds/test_combiner.py +++ b/hail/python/test/hail/vds/test_combiner.py @@ -7,8 +7,7 @@ from hail.utils.misc import new_temp_file from hail.vds.combiner import combine_variant_datasets, new_combiner, load_combiner, transform_gvcf from hail.vds.combiner.combine import defined_entry_fields -from ..helpers import resource, fails_local_backend, fails_service_backend, test_timeout - +from ..helpers import resource, skip_when_service_backend, test_timeout all_samples = ['HG00308', 'HG00592', 'HG02230', 'NA18534', 'NA20760', 'NA18530', 'HG03805', 'HG02223', 'HG00637', 'NA12249', @@ -110,6 +109,7 @@ def test_move_load_combiner_plan(): @test_timeout(10 * 60) +@skip_when_service_backend def test_combiner_run(): tmpdir = new_temp_file() samples = all_samples[:5] From 36307075a2a54ae0b2c232511b6ebc546ae8c3f9 Mon Sep 17 00:00:00 2001 From: Dan King Date: Mon, 17 Jul 2023 09:52:04 -0400 Subject: [PATCH 2/2] add reasong --- hail/python/test/hail/vds/test_combiner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hail/python/test/hail/vds/test_combiner.py b/hail/python/test/hail/vds/test_combiner.py index 151ebb6c62e..a91c4a560c7 100644 --- a/hail/python/test/hail/vds/test_combiner.py +++ b/hail/python/test/hail/vds/test_combiner.py @@ -109,7 +109,7 @@ def test_move_load_combiner_plan(): @test_timeout(10 * 60) -@skip_when_service_backend +@skip_when_service_backend(reason='Combiner makes extensive use of the Backend API which are serviced by starting a Hail Batch job to execute them. This test will be too slow until we change the combiner to use many fewer executes.') def test_combiner_run(): tmpdir = new_temp_file() samples = all_samples[:5]