From d3b1bf79f100087accba5528e258e7a24411a674 Mon Sep 17 00:00:00 2001 From: Dan King Date: Fri, 12 Jan 2024 10:36:50 -0500 Subject: [PATCH] [batch] provide sufficient information to debug transient errors This provides useful feedback we can use to understand why `test_file_in_current_dir` keeps failing. --- .../test/hailtop/hailctl/batch/test_submit.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hail/python/test/hailtop/hailctl/batch/test_submit.py b/hail/python/test/hailtop/hailctl/batch/test_submit.py index aa56da2652a..4142d81db56 100644 --- a/hail/python/test/hailtop/hailctl/batch/test_submit.py +++ b/hail/python/test/hailtop/hailctl/batch/test_submit.py @@ -38,7 +38,7 @@ def test_file_with_no_dest(runner: CliRunner): write_hello(f'{dir}/hello.txt') write_script(dir, f'{dir}/hello.txt') res = runner.invoke(cli.app, ['submit', '--files', 'hello.txt', 'test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_file_in_current_dir(runner: CliRunner): @@ -47,7 +47,7 @@ def test_file_in_current_dir(runner: CliRunner): write_hello(f'{dir}/hello.txt') write_script(dir, f'/hello.txt') res = runner.invoke(cli.app, ['submit', '--files', 'hello.txt:/', 'test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_file_mount_in_child_dir(runner: CliRunner): @@ -56,7 +56,7 @@ def test_file_mount_in_child_dir(runner: CliRunner): write_hello(f'{dir}/hello.txt') write_script(dir, '/child/hello.txt') res = runner.invoke(cli.app, ['submit', '--files', 'hello.txt:/child/', 'test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_file_mount_in_child_dir_to_root_dir(runner: CliRunner): @@ -65,7 +65,7 @@ def test_file_mount_in_child_dir_to_root_dir(runner: CliRunner): write_hello(f'{dir}/child/hello.txt') write_script(dir, '/hello.txt') res = runner.invoke(cli.app, ['submit', '--files', 'child/hello.txt:/', 'test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_mount_multiple_files(runner: CliRunner): @@ -77,7 +77,7 @@ def test_mount_multiple_files(runner: CliRunner): res = runner.invoke( cli.app, ['submit', '--files', 'child/hello1.txt:/', '--files', 'child/hello2.txt:/', 'test_job.py'] ) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_dir_mount_in_child_dir_to_child_dir(runner: CliRunner): @@ -87,7 +87,7 @@ def test_dir_mount_in_child_dir_to_child_dir(runner: CliRunner): write_hello(f'{dir}/child/hello2.txt') write_script(dir, '/child/hello1.txt') res = runner.invoke(cli.app, ['submit', '--files', 'child/:/child/', 'test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_file_outside_curdir(runner: CliRunner): @@ -97,7 +97,7 @@ def test_file_outside_curdir(runner: CliRunner): write_hello(f'{dir}/hello.txt') write_script(dir, '/hello.txt') res = runner.invoke(cli.app, ['submit', '--files', f'{dir}/hello.txt:/', '../test_job.py']) - assert res.exit_code == 0 + assert res.exit_code == 0, (res.output, res.stdout, res.stderr, res.exception) def test_dir_outside_curdir(runner: CliRunner): @@ -108,4 +108,4 @@ def test_dir_outside_curdir(runner: CliRunner): write_hello(f'{dir}/hello2.txt') write_script(dir, '/hello1.txt') res = runner.invoke(cli.app, ['submit', '--files', f'{dir}/:/', '../test_job.py']) - assert res.exit_code == 0, (res.exit_code, res.stdout, res.stderr) + assert res.exit_code == 0, (res.exit_code, res.stdout, res.stderr, res.exception)