Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the section about conditional / delayed S3 registration #1082

Closed
jennybc opened this issue Jul 16, 2024 · 1 comment · Fixed by #1087
Closed

Update the section about conditional / delayed S3 registration #1082

jennybc opened this issue Jul 16, 2024 · 1 comment · Fixed by #1087
Labels
NAMESPACE tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@jennybc
Copy link
Collaborator

jennybc commented Jul 16, 2024

This section:

https://r-pkgs.org/dependencies-in-practice.html#imports-and-exports-related-to-s3

needs to be updated to reflect a cleaner solution that is available from R >= 3.6 and that is newly taken advantage of by roxygen2.

A pull request showing before vs. after is here:

tidyverse/glue#310

@jennybc jennybc changed the title Update the second about conditional / delayed S3 registration Update the section about conditional / delayed S3 registration Jul 16, 2024
@jennybc jennybc added tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day NAMESPACE labels Jul 16, 2024
@jennybc
Copy link
Collaborator Author

jennybc commented Jul 16, 2024

This appears to have been introduced in roxygen2 7.2.0, so not super new:

https://github.com/r-lib/roxygen2/blob/main/NEWS.md#roxygen2-720

@exportS3Method pkg::generic now works when pkg::generic isn't imported by your package (#1085).

Relevant roxygen2 issue: r-lib/roxygen2#1085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NAMESPACE tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant