From 40545adcb7bc4737e2eab3daf4ad3c7b4a7c2895 Mon Sep 17 00:00:00 2001 From: Javier Spagnoletti Date: Sun, 27 Jan 2019 17:31:38 -0300 Subject: [PATCH] Fixed some deprecations --- Command/AutoClosingCommand.php | 4 +++- Command/TicketManagerCommand.php | 4 +++- DependencyInjection/Configuration.php | 10 ++++++++-- Resources/config/services.yml | 10 ++++++++++ 4 files changed, 24 insertions(+), 4 deletions(-) diff --git a/Command/AutoClosingCommand.php b/Command/AutoClosingCommand.php index b0e1236b..e117ec64 100644 --- a/Command/AutoClosingCommand.php +++ b/Command/AutoClosingCommand.php @@ -11,13 +11,15 @@ class AutoClosingCommand extends ContainerAwareCommand { + protected static $defaultName = 'ticket:autoclosing'; + /** * {@inheritdoc} */ protected function configure() { $this - ->setName('ticket:autoclosing') + ->setName(static::$defaultName) // BC for symfony/console < 3.4.0 ->setDescription('Automatically close resolved tickets still opened') ->addArgument( 'username', diff --git a/Command/TicketManagerCommand.php b/Command/TicketManagerCommand.php index 38b6f93d..c73d7e0d 100644 --- a/Command/TicketManagerCommand.php +++ b/Command/TicketManagerCommand.php @@ -11,13 +11,15 @@ class TicketManagerCommand extends ContainerAwareCommand { + protected static $defaultName = 'ticket:create'; + /** * {@inheritdoc} */ protected function configure() { $this - ->setName('ticket:create') + ->setName(static::$defaultName) // BC for symfony/console < 3.4.0 ->setDescription('Create a new Ticket') ->addArgument( 'subject', diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php index fe9b6f80..7d9dd470 100644 --- a/DependencyInjection/Configuration.php +++ b/DependencyInjection/Configuration.php @@ -17,9 +17,15 @@ class Configuration implements ConfigurationInterface */ public function getConfigTreeBuilder() { - $treeBuilder = new TreeBuilder(); + $treeBuilder = new TreeBuilder('hackzilla_ticket'); + if (method_exists($treeBuilder, 'getRootNode')) { + $rootNode = $treeBuilder->getRootNode(); + } else { + // BC layer for symfony/config 4.1 and older + $rootNode = $treeBuilder->root('hackzilla_ticket'); + } - $treeBuilder->root('hackzilla_ticket') + $rootNode ->children() ->scalarNode('user_class')->isRequired()->cannotBeEmpty()->end() ->scalarNode('ticket_class')->cannotBeEmpty()->defaultValue('Hackzilla\Bundle\TicketBundle\Entity\Ticket')->end() diff --git a/Resources/config/services.yml b/Resources/config/services.yml index 5875672c..f2f53d06 100644 --- a/Resources/config/services.yml +++ b/Resources/config/services.yml @@ -70,3 +70,13 @@ services: class: Hackzilla\Bundle\TicketBundle\EventListener\FileSubscriber tags: - { name: kernel.event_subscriber } + + hackzilla_ticket.command.autoclosing: + class: Hackzilla\Bundle\TicketBundle\Command\AutoClosingCommand + tags: + - { name: console.command, command: ticket:autoclosing } + + hackzilla_ticket.command.create: + class: Hackzilla\Bundle\TicketBundle\Command\TicketManagerCommand + tags: + - { name: console.command, command: ticket:create }