Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issue #6

Closed
loreanvictor opened this issue Feb 19, 2018 · 1 comment
Closed

Performance Issue #6

loreanvictor opened this issue Feb 19, 2018 · 1 comment

Comments

@loreanvictor
Copy link

there is a performance issue for this function, which stems from node's (vm package) performance issue in context creation. you could of course just wait for nodejs guys to fix it over there, but for now it stopped me from using this package so thought of giving you a heads up. I ended up using a similar code which also can reuse script and context objects.

@hacksparrow
Copy link
Owner

Fixed in latest versions - nodejs/node#14229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants